Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove dist_ prefix from TORCH_LOGS shortcuts #126499

Closed
wants to merge 1 commit into from
Closed

Remove dist_ prefix from TORCH_LOGS shortcuts #126499

wants to merge 1 commit into from

Conversation

wconstab
Copy link
Contributor

@wconstab wconstab commented May 17, 2024 •
edited

Stack from ghstack (oldest at bottom):

e.g. dist_ddp -> ddp

'distributed' shortcut remains unchained

Feedback has been that it is not appealing to have the dist_ prefix,
and the main reason for it was to keep the distributed shortcuts grouped
together in the help menu. It's nice to have shorter shortcuts.

@wconstab
Update
a90488d 
[ghstack-poisoned]
@wconstab wconstab mentioned this pull request May 17, 2024
Closed
@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented May 17, 2024 •
edited

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/126499

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit a90488d with merge base failed to retrieve merge base, please contact dev infra:
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

wconstab added a commit that referenced this pull request May 17, 2024
@wconstab
Remove dist_ prefix from TORCH_LOGS shortcuts
bf4599c 
e.g. dist_ddp -> ddp

'distributed' shortcut remains unchained

Feedback has been that it is not appealing to have the dist_ prefix,
and the main reason for it was to keep the distributed shortcuts grouped
together in the help menu.  It's nice to have shorter shortcuts.

ghstack-source-id: 3013f58e9efa5fd894976c3bd5fc51183b4bce2b
Pull Request resolved: #126499
@XilunWu
Copy link
Contributor

XilunWu commented May 17, 2024

to turn on c10d log we simply type TORCH_LOGS=c10d now instead of TORCH_LOGS=dist_c10d?

@wconstab
Copy link
Contributor Author

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label May 17, 2024
@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: This PR needs a release notes: label
If your changes are user facing and intended to be a part of release notes, please use a label starting with release notes:.

If not, please add the topic: not user facing label.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "topic: not user facing"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

Details for Dev Infra team Raised by workflow job

@kwen2501
Copy link
Contributor

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

ZelboK pushed a commit to ZelboK/pytorch that referenced this pull request May 19, 2024
@wconstab @ZelboK
Remove dist_ prefix from TORCH_LOGS shortcuts (pytorch#126499)
8ab08f9 
e.g. dist_ddp -> ddp

'distributed' shortcut remains unchained

Feedback has been that it is not appealing to have the dist_ prefix,
and the main reason for it was to keep the distributed shortcuts grouped
together in the help menu.  It's nice to have shorter shortcuts.
Pull Request resolved: pytorch#126499
Approved by: https://github.com/XilunWu, https://github.com/kwen2501
ghstack dependencies: pytorch#126322
@kwen2501 kwen2501 mentioned this pull request May 21, 2024
Closed
kwen2501 added a commit that referenced this pull request May 22, 2024
@kwen2501
Update on "[pipelining] Retire PIPPY_VERBOSITY in favor of TORCH_LOGS…
1a24811 
…=pp"


#126499 established: 

`TORCH_LOGS=pp` --> info
`TORCH_LOGS=-pp` --> warn
`TORCH_LOGS=+pp` --> debug

cc mrshenli pritamdamania87 zhaojuanmao satgera gqchen aazzolini osalpekar jiayisuse H-Huang awgu penguinwu fegin XilunWu wanchaol fduwjj wz337 tianyu-l wconstab yf225 chauhang d4l3k

[ghstack-poisoned]
pytorchmergebot pushed a commit that referenced this pull request May 22, 2024
@kwen2501 @pytorchmergebot
[pipelining] Retire PIPPY_VERBOSITY in favor of TORCH_LOGS=pp (#126828)
608a11c 
#126499 established:

`TORCH_LOGS=pp` --> info
`TORCH_LOGS=-pp` --> warn
`TORCH_LOGS=+pp` --> debug

Pull Request resolved: #126828
Approved by: https://github.com/wconstab
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kwen2501 kwen2501 kwen2501 approved these changes

@XilunWu XilunWu XilunWu approved these changes

@wanchaol wanchaol Awaiting requested review from wanchaol

Assignees
No one assigned
Labels
ciflow/trunk Trigger trunk jobs on your pull request Merged release notes: distributed (tools)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@wconstab @XilunWu @pytorchmergebot @kwen2501