-
Notifications
You must be signed in to change notification settings - Fork 21.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove redundant device guard in Resize.h #126498
base: main
Are you sure you want to change the base?
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/126498
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 55c4b57 with merge base 1018a68 (): This comment was automatically generated by Dr. CI and updates every 15 minutes. |
@pytorchbot merge |
Merge failedReason: Approvers from one of the following sets are needed:
|
CC @Skylion007 for stamp |
Could you please take a look. Thanks Cheers |
hi @Skylion007 @eqy Could you please take a look please. Thanks |
In #113386 a device guard was inserted.
The new inserted device guarded has a clear and more confined guarded scope.
And it's hard to tell the exact purpose and scope of the old device guard.
Removing the guard has negligible positive performance impact and make the code more understandable.
Thanks