Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove redundant device guard in Resize.h #126498

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

kevint324
Copy link

In #113386 a device guard was inserted.

The new inserted device guarded has a clear and more confined guarded scope.
And it's hard to tell the exact purpose and scope of the old device guard.

Removing the guard has negligible positive performance impact and make the code more understandable.

Thanks

@kevint324 kevint324 requested a review from eqy as a code owner May 17, 2024 01:13
Copy link

pytorch-bot bot commented May 17, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/126498

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 55c4b57 with merge base 1018a68 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@kevint324
Copy link
Author

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label May 20, 2024
@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: Approvers from one of the following sets are needed:

  • superuser (pytorch/metamates)
  • Core Reviewers (mruberry, lezcano, Skylion007, ngimel, peterbell10)
  • Core Maintainers (soumith, gchanan, ezyang, dzhulgakov, malfet)
Details for Dev Infra team Raised by workflow job

Failing merge rule: Core Maintainers

@eqy
Copy link
Collaborator

eqy commented May 21, 2024

CC @Skylion007 for stamp

@kevint324
Copy link
Author

Hi @Skylion007 @mruberry

Could you please take a look. Thanks

Cheers

@kevint324
Copy link
Author

hi @Skylion007 @eqy

Could you please take a look please.

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ciflow/trunk Trigger trunk jobs on your pull request open source
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants