Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Submodule] Remove zstd dependency #126485

Closed
wants to merge 1 commit into from
Closed

Conversation

cyyever
Copy link
Collaborator

@cyyever cyyever commented May 17, 2024

After searching in the codebase, it seems that zstd is not in use now.

Copy link

pytorch-bot bot commented May 17, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/126485

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure

As of commit 60f6644 with merge base 337830f (image):

NEW FAILURE - The following job has failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@cyyever cyyever requested a review from r-barnes May 17, 2024 00:30
@cyyever cyyever added topic: not user facing topic category topic: deprecation topic category ciflow/trunk Trigger trunk jobs on your pull request ciflow/binaries Trigger all binary build and upload jobs on the PR labels May 17, 2024
@cyyever cyyever requested review from malfet and ezyang May 17, 2024 00:59
@cyyever
Copy link
Collaborator Author

cyyever commented May 17, 2024

@pytorchmergebot merge -i

@pytorchmergebot
Copy link
Collaborator

This PR updates submodules third_party/zstd

If those updates are intentional, please add "submodule" keyword to PR title/description.

@cyyever cyyever changed the title Remove zstd dependency [Submodule] Remove zstd dependency May 17, 2024
@cyyever
Copy link
Collaborator Author

cyyever commented May 17, 2024

@pytorchmergebot merge -i

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged while ignoring the following 1 checks: windows-binary-wheel / wheel-py3_10-cpu-test

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

ZelboK pushed a commit to ZelboK/pytorch that referenced this pull request May 19, 2024
After searching in the codebase, it seems that zstd is not in use now.

Pull Request resolved: pytorch#126485
Approved by: https://github.com/ezyang
@cyyever cyyever deleted the remove_zstd branch May 23, 2024 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ciflow/binaries Trigger all binary build and upload jobs on the PR ciflow/trunk Trigger trunk jobs on your pull request Merged open source topic: deprecation topic category topic: not user facing topic category
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants