Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dep groupby corrwith #58732

Open
wants to merge 11 commits into
base: main
Choose a base branch
from
Open

Dep groupby corrwith #58732

wants to merge 11 commits into from
+111 −25

Conversation

pedrocariellof
Copy link

rhshadrach
rhshadrach requested changes May 15, 2024
View reviewed changes
Copy link
Member

@rhshadrach rhshadrach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! Looks pretty good, a few requests below.

doc/source/development/policies.rst Outdated Show resolved Hide resolved
doc/source/getting_started/install.rst Outdated Show resolved Hide resolved
doc/source/whatsnew/v3.0.0.rst Outdated Show resolved Hide resolved
pandas/tests/groupby/test_all_methods.py Outdated Show resolved Hide resolved
pandas/tests/groupby/test_all_methods.py Outdated Show resolved Hide resolved
pandas/core/groupby/generic.py Show resolved Hide resolved
@rhshadrach rhshadrach added Groupby Deprecate Functionality to remove in pandas labels May 15, 2024
@pedrocariellof
Copy link
Author

@rhshadrach

rhshadrach
rhshadrach requested changes May 29, 2024
View reviewed changes
Copy link
Member

@rhshadrach rhshadrach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, a few minor requests.

doc/source/getting_started/install.rst Outdated Show resolved Hide resolved
doc/source/whatsnew/v3.0.0.rst Outdated Show resolved Hide resolved
doc/source/whatsnew/v3.0.0.rst Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@noatamir noatamir Awaiting requested review from noatamir

@rhshadrach rhshadrach Awaiting requested review from rhshadrach rhshadrach is a code owner

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
Deprecate Functionality to remove in pandas Groupby
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

DEPR: groupby.corrwith
3 participants
@pedrocariellof @rhshadrach @tomytp