BUG: Assignment of pyarrow arrays yield unexpected dtypes #58601
+22
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ssignment-unexpected-dtypes
…ssignment-unexpected-dtypes
3 tasks
WillAyd
reviewed
May 16, 2024
pandas/core/frame.py
Outdated
| from pandas.compat._constants import REF_COUNT | ||
| from pandas.compat._optional import import_optional_dependency | ||
| from pandas.compat.numpy import function as nv | ||
|
|
||
| if not pa_version_under11p0: |
There was a problem hiding this comment.
What prevents this from working with pyarrow 10?
There was a problem hiding this comment.
Nothing prevents it ! :-)
It was a misanderstanding.
At the beginning I thought that the version 11.0.0 was the minimum version (because "Minimum Versions" tests in the CI were not working with pyarrow 10). But actually value in _sanitize_column is:
- A
pa.lib.ChunkedArrayin version10.0.1 - A
pa.lib.Arrayin versions above
So now I just test ifvalueis an instance of the parent classpa.lib._PandasConvertible
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.During a column assignment in a
DataFrame,sanitize_arrayis called with adtypeequals toArrowDtype(value.type)if the columnvalueis apa.lib._PandasConvertible(else the standard behaviour is kept)