Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix BUG #58524 #58541

Closed

Conversation

Nrezhang
Copy link
Contributor

@Nrezhang Nrezhang commented May 2, 2024

Changed it to check the last character of the string so it handles if numbers in front. Works with the example, but not sure about if there are other cases that would break this. The fix seems almost too simple. Let me know :)

@Nrezhang
Copy link
Contributor Author

Nrezhang commented May 2, 2024

Modified my PR to parse the characters in freqstr and check that for more flexibility

@Nrezhang
Copy link
Contributor Author

Nrezhang commented May 3, 2024

Hi, when I run the pre-commit hooks pre-commit run --hook-stage manual --all-files, all the lines pass, but it seems like I have many failing checks. Could I have some guidance with how to understand which tests are failing and if there are issues with how I write my code? Thanks

@Aloqeely
Copy link
Member

Aloqeely commented May 3, 2024

Hey, the pre-commit code checks are actually passing, the problem here is that some of the unit tests are failing

See this guide for running the unit tests locally: https://pandas.pydata.org/docs/dev/development/contributing_codebase.html#running-the-test-suite

@mroeschke
Copy link
Member

Thanks for the pull request, but it appears to have gone stale. If interested in continuing, please merge in the main branch, address any review comments and/or failing tests, and we can reopen.

@mroeschke mroeschke closed this May 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: DatetimeIndex.is_year_start breaks for business-day frequency where n is greater than 1
3 participants