Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Properly detect attribute format types #17685

Merged
merged 1 commit into from
May 17, 2024
Merged

Properly detect attribute format types #17685

merged 1 commit into from
May 17, 2024

Conversation

vkalintiris
Copy link
Contributor

Summary

Use a fail regex to disable the definition when a warning is printed.

Test Plan
  • CI jobs.
  • No format-related warnings when compiling with this PR.

@vkalintiris vkalintiris requested a review from stelfrag May 16, 2024 14:57
@vkalintiris vkalintiris self-assigned this May 16, 2024
@vkalintiris vkalintiris requested review from a team, Ferroin and thiagoftsm as code owners May 16, 2024 14:57
@github-actions github-actions bot added area/packaging Packaging and operating systems support area/collectors Everything related to data collection area/build Build system (autotools and cmake). labels May 16, 2024
@vkalintiris vkalintiris merged commit 12b178c into netdata:master May 17, 2024
148 of 149 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ilyam8 ilyam8 ilyam8 approved these changes

@stelfrag stelfrag Awaiting requested review from stelfrag

@Ferroin Ferroin Awaiting requested review from Ferroin Ferroin is a code owner

@thiagoftsm thiagoftsm Awaiting requested review from thiagoftsm thiagoftsm is a code owner

Assignees

@vkalintiris vkalintiris

Labels
area/build Build system (autotools and cmake). area/collectors Everything related to data collection area/packaging Packaging and operating systems support
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@vkalintiris @ilyam8