Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

p/pronterface: Fix unknown wx locale #1351

Merged
merged 1 commit into from
May 13, 2023
Merged

p/pronterface: Fix unknown wx locale #1351

merged 1 commit into from
May 13, 2023

Conversation

rockstorm101
Copy link
Collaborator

Function wx.Locale.GetSystemLanguage returns wx.LANGUAGE_UNKNOWN when unable to identify the system's language. And wx.Locale constructor does not allow wx.LANGUAGE_UNKNOWN as an argument.

Fixes #1345
Fixes #1348

CC @DivingDuck @neofelis2X could you give this a try and confirm it works?

Function `wx.Locale.GetSystemLanguage` returns `wx.LANGUAGE_UNKNOWN`
when unable to identify the system's language. And `wx.Locale`
constructor does not allow `wx.LANGUAGE_UNKNOWN` as an argument.

Fixes #1345
Fixes #1348
@DivingDuck
Copy link
Collaborator

DivingDuck commented May 10, 2023

@rockstorm101,
guess, we should remove py 3.6 from:
pypi-mac.yml
pypi-win.yml
Thought, I did it for windows already, but it seems I did't...
It isn't compatible with wxPython 4.2 if I remember correct.

@DivingDuck
Copy link
Collaborator

Forgot to mention that this fix work fine on my windows system. (but I wasn't able to reproduce this error on my windows computers). I would suggest to implement it as it is nice way to avoid a not defined language setup.

@rockstorm101
Copy link
Collaborator Author

@rockstorm101, guess, we should remove py 3.6 from: pypi-mac.yml pypi-win.yml Thought, I did it for windows already, but it seems I did't... It isn't compatible with wxPython 4.2 if I remember correct.

Hi @DivingDuck, you say this because of the workflow failures I guess. It turns out GitHub was having issues on their servers yesterday. The workflows for Windows run well for PR #1352 today. Which takes me to, do we really need PR #1353 now? I guess it'll be needed some day at some point though.

@DivingDuck
Copy link
Collaborator

Hi @rockstorm101,
yes, this was why I looked into this and found those open ends. Good to know.

I think we shouldn't build all those environments if we can't use them at all. wxpython 4.2 won't support any of this versions for windows. I like to minimize the use of resources (and possible errors for not used stuff). I must confess that I forgot to check this again when we build 2.0.

For macOS it looks like they are on the way to stop support for macOS 10.15:
https://github.blog/changelog/2022-07-20-github-actions-the-macos-10-15-actions-runner-image-is-being-deprecated-and-will-be-removed-by-8-30-22/

@neofelis2X
Copy link
Contributor

Hello @rockstorm101 . I tested this and doesn't cause any errors on macOS. Looks good to me!
But I'm also not able to force this issue. I tried to overwrite my terminal session with export LANG=... LC_ALL=.... But Pronterface ignores this and always recognises and loads my global locale.

@rockstorm101 rockstorm101 merged commit 9c16540 into patches May 13, 2023
23 of 62 checks passed
@rockstorm101 rockstorm101 deleted the fix-1345 branch May 13, 2023 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants