interpolation added for TVP. #30863
Open
interpolation added for TVP. #30863
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nmdev/transformers into interpolate-pos-encode-tvp
amyeroberts
reviewed
May 20, 2024
12 tasks
amyeroberts
reviewed
May 23, 2024
There was a problem hiding this comment.
Thanks for the continued work on this!
Please make sure to either comment on suggestions why you're not implementing them or implement the suggestion before marking as resolved. Comments making suggestions to make e.g. docstrings in-line with the library standard will have to be implemented
Comment on lines
300
to
301
| expected_shape = torch.Size((1, 2)) | ||
| assert outputs.logits.shape == expected_shape |
|
@bhuvanmdev For the quality checks could you:
|
|
@amyeroberts Done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds interpolation to the tvp model for the position and pad embeddings.
Addresses #30579
Who can review?
@amyeroberts