Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow JS Client to work with authenticated spaces 🍪 #8299

Merged
merged 11 commits into from
May 22, 2024
Merged

Conversation

hannahblair
Copy link
Collaborator

@hannahblair hannahblair commented May 16, 2024

Description

This PR allows the connection to or duplication of spaces with authentication enabled. We get the cookie response from /login and if the response is ok then we parse and add the received access tokens to the the client's this.fetch function's headers.Cookie so all subsequent fetch requests will be authenticated.

Note: This won't work with EventSource as I haven't added the logic for this, since we're moving away from it anyway.

Closes: #2266

🎯 PRs Should Target Issues

Before your create a PR, please check to see if there is an existing issue for this change. If not, please create an issue before you create this PR, unless the fix is very small.

Not adhering to this guideline will result in the PR being closed.

Tests

  1. PRs will only be merged if tests pass on CI. To run the tests locally, please set up your Gradio environment locally and run the tests: bash scripts/run_all_tests.sh

  2. You may need to run the linters: bash scripts/format_backend.sh and bash scripts/format_frontend.sh

@gradio-pr-bot
Copy link
Contributor

gradio-pr-bot commented May 16, 2024

🪼 branch checks and previews

Name Status URL
Spaces ready! Spaces preview
Website failed! Details
🦄 Changes detected! Details

Install Gradio from this PR

pip install https://gradio-builds.s3.amazonaws.com/4734490e8a18c8f628c10cde888b55d0e2655ba3/gradio-4.31.3-py3-none-any.whl

Install Gradio Python Client from this PR

pip install "gradio-client @ git+https://github.com/gradio-app/gradio@4734490e8a18c8f628c10cde888b55d0e2655ba3#subdirectory=client/python"

@gradio-pr-bot
Copy link
Contributor

gradio-pr-bot commented May 16, 2024

🦄 change detected

This Pull Request includes changes to the following packages.

Package Version
@gradio/client minor
gradio minor
  • Maintainers can select this checkbox to manually select packages to update.

With the following changelog entry.

Allow JS Client to work with authenticated spaces 🍪

Maintainers or the PR author can modify the PR title to modify this entry.

Something isn't right?

  • Maintainers can change the version label to modify the version bump.
  • If the bot has failed to detect any changes, or if this pull request needs to update multiple packages to different versions or requires a more comprehensive changelog entry, maintainers can update the changelog file directly.

@hannahblair hannahblair marked this pull request as ready for review May 16, 2024 23:53
Copy link
Member

@pngwn pngwn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks for taking care of this @hannahblair!

@hannahblair hannahblair merged commit ab65360 into main May 22, 2024
9 checks passed
@hannahblair hannahblair deleted the jsclientauth branch May 22, 2024 10:02
@pngwn pngwn mentioned this pull request May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Let JS client work with Gradio apps with auth
3 participants