Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Test Suite False Positive #217

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix Test Suite False Positive #217

wants to merge 1 commit into from

Conversation

snuggs
Copy link
Member

@snuggs snuggs commented Jan 6, 2021

Description

Test suite ALWAYS returns 0 (true/successful) due to an echo being at the end of the file. The test suite is actually broken.

How Has This Been Tested?

snuggsi test

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Screenshots (if appropriate):

Capture d’écran 2021-01-06 à 08 08 14

@vercel
Copy link

vercel bot commented Jan 6, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/sneakyhead/snuggsi/l74m2n77z
✅ Preview: https://snuggsi-git-fix-test-suite-run.sneakyhead.vercel.app

JoshuaBehrens
JoshuaBehrens previously approved these changes Jan 6, 2021
Copy link
Collaborator

@JoshuaBehrens JoshuaBehrens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants