Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

鈿狅笍 馃摉 DRAFT: <tag-complete> #117

Open
wants to merge 13 commits into
base: main
Choose a base branch
from

Conversation

snuggs
Copy link
Member

@snuggs snuggs commented Jul 22, 2017

<tag-complete>

Inspiration drawn from @kurtcagle's tags. @kurtcagle if you can drop the codepen in the description that would be great. Also gives you the chance to catch up to speed with the lifecycle callbacks.

https://snuggsi.now.sh#lifecycle please give it a moment as there is a 30s warmup time with the free plan at https://now.sh

Coparable Examples

Demonstration

email-recipients

<email-recipients>

<template name=recipients>
<address>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is address allowed to be email address, not just physical? TIL

Copy link
Member Author

@snuggs snuggs Jul 22, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


</script>

<script src=/browser-sync.es></script>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what if we load this conditionally based on localhost?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah, hadn't picked up on that. well played.


email-recipients > address:hover,
email-recipients {
box-shadow: 0 0 0.28em rgba(40,40,40,0.8);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no spaces between rgba values?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@brandondees i'm down with that

Copy link
Member Author

@snuggs snuggs Jul 22, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@albertoponti @brandondees hit me with "Tsu"! f783911

@snuggs snuggs requested a review from kurtcagle July 22, 2017 02:32
@snuggs snuggs changed the title <email-recipients> 鈿狅笍 馃摉 DRAFT:<email-recipients> Jul 22, 2017
@snuggs snuggs changed the title 鈿狅笍 馃摉 DRAFT:<email-recipients> 鈿狅笍 馃摉 DRAFT: <email-recipients> Jul 22, 2017
@snuggs
Copy link
Member Author

snuggs commented Jul 30, 2017

@brandondees @kurtcagle name rechange to <tag-complete>

@brandondees
Copy link
Collaborator

yeah generalize the names to what the component actually does, rather than the specific use case for it. be sure to list known use-cases in the documentation but I'm all for more generic components.

@brandondees
Copy link
Collaborator

a consumer can always wrap them in their own context-specific name at import time, btw

@snuggs
Copy link
Member Author

snuggs commented Jul 31, 2017

@brandondees OR use an identifier <tag-complete id=recipients> There's a way to finesse that yes?

@brandondees
Copy link
Collaborator

no i mean <link rel=import href=your-element.html name=my-element>

@snuggs snuggs changed the title 鈿狅笍 馃摉 DRAFT: <email-recipients> 鈿狅笍 馃摉 DRAFT: <tag-complete> Aug 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants