[27.x] Backports and rc1 #30092
[27.x] Backports and rc1 #30092
Conversation
Github-Pull: bitcoin-core/gui#812 Rebased-From: 671b7a3
Fixes: bitcoin#809 Previously it was possible through the GUI to enter an IP address:port into the "Proxy IP" configuration box. After the node was restarted the errant setting would prevent the node starting back up until manually removed from settings.json. Github-Pull: bitcoin-core/gui#813 Rebased-From: 10c5275
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. Code CoverageFor detailed information about the code coverage, see the test coverage report. ReviewsSee the guideline for information on the review process.
If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update. |
Without explicitly declaring the move, these UniValues get copied, causing increased memory usage. Fix this by explicitly moving the UniValue objects. Used by `rest_block` and `getblock` RPC. Github-Pull: bitcoin#30094 Rebased-From: b77bad3
|
Propose #30085 if merged in time. |
Clang is unable to compile the Transform function for that combination of options. Github-Pull: bitcoin#30097 Rebased-From: 141df0a
Addnode (manual) peers connected to us via the cjdns network are currently not detected by CConnman::GetAddedNodeInfo(), i.e. fConnected is always false. This causes the following issues: - RPC `getaddednodeinfo` incorrectly shows them as not connected - CConnman::ThreadOpenAddedConnections() continually retries to connect them Github-Pull: bitcoin#30085 Rebased-From: 684da97
fanquake
changed the title
Github-Pull: bitcoin#30085 Rebased-From: d0b0474
The https://miniupnp.tuxfamily.org website is unavailable now. Github-Pull: bitcoin#30151 Rebased-From: 21b8a14
Github-Pull: bitcoin#30149 Rebased-From: 9f4ff1e
There was a problem hiding this comment.
ACK cb6def3
Reviewed that all backports were unmodified, and that associated PR #'s match.
Lightly reviewed release notes and manpage and they look good to me.
There was a problem hiding this comment.
ACK cb6def3 modulo small release notes fix
All backport commits are clean, except for:
- 77b2321 backported from 21b8a14: version bumped in depends: build miniupnpc with CMake #29707 - LGTM
No diff with my local manpage generation.
doc/release-notes.md
Outdated
| Bitcoin Core version 27.1 is now available from: | ||
|
|
||
| <https://bitcoincore.org/bin/bitcoin-core-27.1/> |
There was a problem hiding this comment.
| Bitcoin Core version 27.1 is now available from: | |
| <https://bitcoincore.org/bin/bitcoin-core-27.1/> | |
| Bitcoin Core version 27.1rc1 is now available from: | |
| <https://bitcoincore.org/bin/bitcoin-core-27.1/test.rc1/> |
There was a problem hiding this comment.
nit but text is not updated to "271.rc1" in latest force push (link is fine now)
There was a problem hiding this comment.
ACK cb6def3.
Feel free to update translations with python3 ../bitcoin-maintainer-tools/update-translations.py or cherry-pick the hebasto@c9c42cc commit.
There was a problem hiding this comment.
reACK f30e23e
Didn't review the newly-added individual translations, but apart from that changes LGTM.
doc/release-notes.md
Outdated
| Bitcoin Core version 27.1 is now available from: | ||
|
|
||
| <https://bitcoincore.org/bin/bitcoin-core-27.1/> |
There was a problem hiding this comment.
nit but text is not updated to "271.rc1" in latest force push (link is fine now)
|
re-ACK 22701a4 |
Backports:
Bump to 27.1rc1.