Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Data Zoom scrolls using the mouse #28559

Merged
merged 3 commits into from
May 21, 2024
Merged

feat: Data Zoom scrolls using the mouse #28559

merged 3 commits into from
May 21, 2024

Conversation

visharavana
Copy link

SUMMARY

To scroll in the data zoom option, we initially had to press and hold down the zoom handle, but now we can also use the mouse for this function.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Before:

Beforezoomscroll.mp4

After:

Afterzoomscroll.mp4

ADDITIONAL INFORMATION

  • Introduces new feature or API

@dosubot dosubot bot added viz:charts:echarts Related to Echarts viz:charts:timeseries Related to Timeseries labels May 17, 2024
Copy link
Member

@rusackas rusackas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rusackas
Copy link
Member

Looks like you need to run the pre-commit hooks.

@visharavana
Copy link
Author

visharavana commented May 18, 2024

Looks like you need to run the pre-commit hooks.

@rusackas I am new to this, so can you guide me?

Copy link

codecov bot commented May 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.71%. Comparing base (5de4862) to head (210c61e).
Report is 21 commits behind head on 4.0.

Additional details and impacted files
@@            Coverage Diff             @@
##              4.0   #28559      +/-   ##
==========================================
+ Coverage   69.65%   69.71%   +0.05%     
==========================================
  Files        1910     1912       +2     
  Lines       74936    74923      -13     
  Branches     8425     8434       +9     
==========================================
+ Hits        52200    52231      +31     
+ Misses      20671    20627      -44     
  Partials     2065     2065              
Flag Coverage Δ
javascript 57.52% <ø> (+0.14%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hughhhh hughhhh merged commit 145fd84 into apache:4.0 May 21, 2024
24 checks passed
@visharavana visharavana deleted the 4.0 branch May 24, 2024 04:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants