Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI changes for DAG Reparsing feature #39636

Merged
merged 10 commits into from
May 22, 2024
Merged

Conversation

utkarsharma2
Copy link
Contributor

This PR introduces the UI changes required to consume the DAG Reparsing API.

Home page

Screenshot 2024-05-15 at 4 59 07 PM

Detail page

Screenshot 2024-05-15 at 4 59 25 PM

related: #39138

@boring-cyborg boring-cyborg bot added area:UI Related to UI/UX. For Frontend Developers. area:webserver Webserver related Issues labels May 15, 2024
@utkarsharma2 utkarsharma2 marked this pull request as draft May 15, 2024 11:30
@phanikumv phanikumv added this to the Airflow 2.10.0 milestone May 15, 2024
@utkarsharma2 utkarsharma2 marked this pull request as ready for review May 17, 2024 12:45
@eladkal
Copy link
Contributor

eladkal commented May 19, 2024

The icon might be misleading. It may be confused with refresh page

@raphaelauv
Copy link
Contributor

maybe something like

re_parse

@utkarsharma2
Copy link
Contributor Author

maybe something like

re_parse

@raphaelauv To me, this looks like searching a file, but I'm not sure what would be better.
@bbovenzi Any suggestions?

@raphaelauv
Copy link
Contributor

@utkarsharma2 yes you are right

then this ?

image

@bbovenzi
Copy link
Contributor

@utkarsharma2 yes you are right

then this ?

image

Let's try it and see if it's not too detailed for the size we display it at.

@utkarsharma2
Copy link
Contributor Author

utkarsharma2 commented May 21, 2024

@utkarsharma2 yes you are right

then this ?

image

I'm not able to find this icon in airflow's supported lib - https://materializecss.com/icons.html.

But the closest icon I could find looks like this -
Screenshot 2024-05-21 at 7 38 16 PM

Screenshot 2024-05-21 at 7 38 29 PM

@bbovenzi
Copy link
Contributor

Looks great to me!

Do the Dags list and dag details pages refresh once the DAG is reparsed?

@utkarsharma2
Copy link
Contributor Author

Do the Dags list and dag details pages refresh once the DAG is reparsed?

Yes, the redirect URL part handles it, right now.

Copy link
Contributor

@bbovenzi bbovenzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice work!

@utkarsharma2 utkarsharma2 merged commit 2250a1a into apache:main May 22, 2024
39 checks passed
@utkarsharma2 utkarsharma2 deleted the UI_DagReparsing branch May 22, 2024 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:UI Related to UI/UX. For Frontend Developers. area:webserver Webserver related Issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants