Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Render map_index_template when the task status is set manually #39505

Closed
wants to merge 0 commits into from

Conversation

karenbraganz
Copy link

@karenbraganz karenbraganz commented May 8, 2024

Render map_index_template when task status is manually set

I made render_map_index a class method in task_instance.py and called it in the set_task_instance_state method in dag.py. I am currently working on debugging the following exception in my code which happens when the self.rendered_map_index = jinja_env.from_string(template).render(context) statement is executed (when render_map_index method from taskinstance.py is called).
image

As of now, my code is aimed at rendering the map_index_template when an individual mapped task instance is marked "succes" in the UI. Once I am able to get this working, I will change it so that it also can render the map_index_template of all mapped task instances when the entire task instance is marked as success. To replicate the exception I am seeing, do the following:

  1. Create a DAG with a mapped task (I used the example in the issue)
  2. Trigger it in the UI
  3. Navigate to the task instance square in grid view
  4. Navigate to the Mapped Tasks[] tab
  5. Click on one of the mapped task instances that is not already running
  6. Use the blue "Mark state as..." button on the top right to mark the mapped task instance state as "success"

Please note that this exception only happens when the state is manually set, not when the task executes automatically. Hence, the changes don't affect current functionality.


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

Copy link

boring-cyborg bot commented May 8, 2024

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
Here are some useful points:

  • Pay attention to the quality of your code (ruff, mypy and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
  • Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: dev@airflow.apache.org
    Slack: https://s.apache.org/airflow-slack

@uranusjr
Copy link
Member

This runs the Jinja template in the webserver. I don’t think it is viable.

@karenbraganz
Copy link
Author

@uranusjr could you please clarify why rendering the template on the webserver is not viable? Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants