Delete redundant xcat methods that previously improved performance #54477
+0
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We might want to run PkgEval to see if any packages will need to be fixed also. Or at least check on the next nightly run if any package test was relying on this |
KristofferC
added
needs pkgeval
|
The See also: JuliaSparse/SparseArrays.jl#431, #52386, #52263 The performance reasons for these defs are gone, but there may be ambiguity reasons. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deleting these because I ran
./julia --startup-file=no --inline=no -e '@time Base.runtests("ranges")'before and after this PR and found a 2 second (1%) regression, which is within margin of error of zero and way less than the original performance improvement when these were added in 2015 in #11158 by @timholy