Use html as scroll container for recent view.
#30134
Open
+559
−564
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amanagr
changed the title
html as scroll container from recent view.html as scroll container for recent view.
amanagr
force-pushed
the
rt_scroll_html
branch
2 times, most recently
from
42bf7aa
to
6de22ad
Compare
amanagr
changed the title
html as scroll container for recent view.html as scroll container for recent view.
|
Works for me in light manual testing! |
amanagr
added a commit
to amanagr/zulip
that referenced
this pull request
May 22, 2024
The bug is hard to reproduce, but I was able to reproduce with zulip#30134 and used the same strategy to fix it here.
amanagr
added a commit
to amanagr/zulip
that referenced
this pull request
May 23, 2024
The bug is hard to reproduce, but I was able to reproduce with zulip#30134 and used the same strategy to fix it here.
timabbott
pushed a commit
to amanagr/zulip
that referenced
this pull request
May 23, 2024
The bug is hard to reproduce, but I was able to reproduce with zulip#30134 and used the same strategy to fix it here.
timabbott
pushed a commit
that referenced
this pull request
May 23, 2024
The bug is hard to reproduce, but I was able to reproduce with #30134 and used the same strategy to fix it here.
|
Pushed to resolve conflicts. |
Since we moved to use standard empty view handlebars everywhere, this became stale.
Instead of `recent_view_table`, we make `html` as our scroll container. This fixes an important bug for us where filters sometimes disappear due to them scrolling under navbar which is unexpected. Since we are now using separate containers to display rows and filter (while includes table headers), where filters use sticky positioning, this bug will be fixed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
discussion: https://chat.zulip.org/#narrow/stream/9-issues/topic/recent.20conversations.20loses.20filter.20checkboxes
Things I tested:
Combined feed-> recent view correctly sets focus to first row.