Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

personal_menu: Move the theme switcher above the status settings. #30129

Merged
merged 1 commit into from
Jun 5, 2024

Conversation

sayamsamal
Copy link
Collaborator

@sayamsamal sayamsamal commented May 18, 2024

This moves the theme switcher from the randomly placed position to the
settings group since it is one of the user preference settings.

CZO Discussion

Screenshots and screen captures:

Before After
image image
Self-review checklist
  • Self-reviewed the changes for clarity and maintainability
    (variable names, code reuse, readability, etc.).

Communicate decisions, questions, and potential concerns.

  • Explains differences from previous plans (e.g., issue description).
  • Highlights technical choices and bugs encountered.
  • Calls out remaining decisions and concerns.
  • Automated tests verify logic where appropriate.

Individual commits are ready for review (see commit discipline).

  • Each commit is a coherent idea.
  • Commit message(s) explain reasoning and motivation for changes.

Completed manual review and testing of the following:

  • Visual appearance of the changes.
  • Responsiveness and internationalization.
  • Strings and tooltips.
  • End-to-end functionality of buttons, interactions and flows.
  • Corner cases, error conditions, and easily imagined bugs.

@sayamsamal
Copy link
Collaborator Author

sayamsamal commented May 18, 2024

@timabbott this should be a quick merge, only moved some lines of code.

(Edit: There may be some discussion still on the way, so removed the integration label)

@sayamsamal sayamsamal added integration review Added by maintainers when a PR may be ready for integration. and removed integration review Added by maintainers when a PR may be ready for integration. labels May 18, 2024
@alya
Copy link
Contributor

alya commented Jun 3, 2024

Can you resolve the conflicts so that we can get this merged, please?

@sayamsamal
Copy link
Collaborator Author

@timabbott @alya I have removed the merge conflicts and updated the PR to move the theme switcher to the settings group, following the latest discussions at CZO.

@sayamsamal sayamsamal added the integration review Added by maintainers when a PR may be ready for integration. label Jun 4, 2024
@timabbott
Copy link
Sponsor Member

I'm going to let you resolve the merge conflict, since there's an actual decision to me made there.

This moves the theme switcher from the randomly placed position to the
settings group since it is one of the user preference settings.
@sayamsamal
Copy link
Collaborator Author

@timabbott I have resolved the merge conflict, ready for integration.

@timabbott timabbott merged commit 09bf7d0 into zulip:main Jun 5, 2024
7 checks passed
@timabbott
Copy link
Sponsor Member

Merged, thanks @sayamsamal!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integration review Added by maintainers when a PR may be ready for integration. size: M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants