Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Actions: support empty args and empty response #11041

Merged
merged 3 commits into from
May 15, 2024

Conversation

bholmesdev
Copy link
Contributor

@bholmesdev bholmesdev commented May 14, 2024

Changes

We raised a 500 when an action's arguments or return value were undefined. This follows the HTTP spec to respect these cases.

  • Return a 204 when the response is empty.
  • Include the Content-Length on JSON args to check for a length of zero.
  • Misc: return a 404 instead of a 500 when requesting an action that doesn't exist.

Testing

Add test for 204 status.

Docs

N/A

Copy link

changeset-bot bot commented May 14, 2024

🦋 Changeset detected

Latest commit: b1e66d7

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the pkg: astro Related to the core `astro` package (scope) label May 14, 2024
@florian-lefebvre florian-lefebvre linked an issue May 15, 2024 that may be closed by this pull request
1 task
.changeset/many-guests-yell.md Outdated Show resolved Hide resolved
Co-authored-by: Florian Lefebvre <contact@florian-lefebvre.dev>
@bholmesdev bholmesdev merged commit 6cc3fb9 into main May 15, 2024
13 checks passed
@bholmesdev bholmesdev deleted the fix/actions-without-return-value branch May 15, 2024 11:42
@astrobot-houston astrobot-houston mentioned this pull request May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: astro Related to the core `astro` package (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Action unexpected end of json input
3 participants