Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

actions: Throw error on missing server output #11028

Merged
merged 5 commits into from
May 14, 2024

Conversation

bholmesdev
Copy link
Contributor

Changes

Throw error when output is missing when using actions.

Testing

Manual testing

Docs

Already documented!

Copy link

changeset-bot bot commented May 13, 2024

🦋 Changeset detected

Latest commit: 8cb5bc8

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the pkg: astro Related to the core `astro` package (scope) label May 13, 2024
Copy link
Member

@ematipico ematipico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What @Princesseuh said, you should use isServerLikeOutput

@github-actions github-actions bot added the docs pr A PR that includes documentation for review label May 14, 2024
@bholmesdev
Copy link
Contributor Author

@Princesseuh @ematipico made those adjustments and added an errors-data entry! Ready for re-review.

@bholmesdev
Copy link
Contributor Author

@Princesseuh Thanks, added

Copy link
Member

@Princesseuh Princesseuh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the error message could be improved, but nothing we can't do later. Awesome!

@bholmesdev bholmesdev merged commit 771d1f7 into main May 14, 2024
13 checks passed
@bholmesdev bholmesdev deleted the feat/throw-actions-missing-output branch May 14, 2024 17:29
@astrobot-houston astrobot-houston mentioned this pull request May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs pr A PR that includes documentation for review pkg: astro Related to the core `astro` package (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants