feat(astro): experimental astro:env #10974
Open
+1,553
−184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Bjorn Lu <bjornlu.dev@gmail.com> Co-authored-by: Emanuele Stoppa <my.burning@gmail.com>
Co-authored-by: Bjorn Lu <bjornlu.dev@gmail.com> Co-authored-by: Emanuele Stoppa <my.burning@gmail.com>
Co-authored-by: Bjorn Lu <bjornlu.dev@gmail.com> Co-authored-by: Emanuele Stoppa <my.burning@gmail.com>
🦋 Changeset detectedLatest commit: 593c254 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
pkg: astro
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
!preview astro-env |
|
Snapshots have been released for the following packages:
Publish LogBuild Log |
bluwy
reviewed
May 9, 2024
|
!preview astro-env |
|
Snapshots have been released for the following packages:
Publish LogBuild Log |
|
!preview astro-env |
|
Snapshots have been released for the following packages:
Publish LogBuild Log |
|
!preview astro-env |
|
Snapshots have been released for the following packages:
Publish LogBuild Log |
|
!preview astro-env |
|
Snapshots have been released for the following packages:
Publish LogBuild Log |
|
!preview astro-env |
|
Snapshots have been released for the following packages:
Publish LogBuild Log |
dreyfus92
reviewed
May 16, 2024
There was a problem hiding this comment.
This looks great @florian-lefebvre! I've made a few rewording suggestions. Feel free to usr or modify as needed! 😁
Co-authored-by: Paul Valladares <85648028+dreyfus92@users.noreply.github.com>
Co-authored-by: Paul Valladares <85648028+dreyfus92@users.noreply.github.com>
Co-authored-by: Paul Valladares <85648028+dreyfus92@users.noreply.github.com>
Co-authored-by: Paul Valladares <85648028+dreyfus92@users.noreply.github.com>
|
!preview astro-env |
|
Snapshots have been released for the following packages:
Publish LogBuild Log |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
astro:env. View RFC Astro Env roadmap#894What to review
I'm mostly looking for reviews on
astro:env/setup: https://github.com/withastro/astro/pull/10974/files#diff-d08d0989a863f87bfceda052de858b8d03124b6bfbff8e084ffbef31240bb446, https://github.com/withastro/astro/pull/10974/files#diff-a95d41705ded14985c748b640b26f3226a7c37d714a8f2fe6171252a59e9941eR79-R81, https://github.com/withastro/astro/pull/10974/files#diff-f982c118ef9afa9c2d69b474b2e206e460b62068cccb0061a5b4eccfe81c708bAlso worth reviewing the adapters pr to see how it will be used for real.
Testing
Unit and integration tests
Docs
Added changeset and config reference