Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add template files to package #347

Open
wants to merge 1 commit into
base: release/v0.4.1-rc
Choose a base branch
from
Open

Add template files to package #347

wants to merge 1 commit into from

Conversation

kvid
Copy link
Collaborator

@kvid kvid commented May 16, 2024

Specify all HTML files under templates folder to be included as package data files.

Is this sufficient to fix #345? Some sources claim that include_package_data=True also is needed, but preliminary testing at my Windows setup seems to prove otherwise. I would prefer that some ohers could confirm at different platforms and versions.

  • Verify in Windows
  • Verify in Linux
  • Verify in macOS

Specify all HTML files under templates folder
to be included as package data files.
@kvid
Copy link
Collaborator Author

kvid commented May 19, 2024

Suggested test procedure:

cd {some empty folder}
python3 -m venv .venv
source .venv/bin/activate
git clone https://github.com/wireviz/WireViz --branch=fix345
cd WireViz
pip install .
cp examples/demo0?.yml ..
cd ..
rm -rf WireViz
wireviz demo0?.yml
which wireviz

or at Windows:

cd {some empty folder}
python3 -m venv .venv
call .venv/Scripts/activate.bat
git clone https://github.com/wireviz/WireViz --branch=fix345
cd WireViz
pip install .
copy examples/demo0?.yml ..
cd ..
rmdir /s /q WireViz
wireviz demo0?.yml
where wireviz

@kvid kvid linked an issue May 25, 2024 that may be closed by this pull request
@kvid kvid mentioned this pull request May 25, 2024
11 tasks
@kvid kvid changed the base branch from master to release/v0.4.1-rc May 25, 2024 16:38
@kvid kvid requested a review from formatc1702 June 1, 2024 01:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant