Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add cancel button #106

Merged
merged 2 commits into from
May 20, 2024
Merged

add cancel button #106

merged 2 commits into from
May 20, 2024

Conversation

three-water666
Copy link
Contributor

I have identified a few existing issues:

  1. The popup after selecting an element lacks a cancel button. If the input is empty and you click submit, you cannot continue selecting a new element.
  2. If you fill in the input and submit, you can still continue to select , but icon's state changes.

So, I did the following work: added a cancel button and improved the logic in this part. If you click the cancel button, you can continue selecting elements. If you click submit, you need to trigger the process again.

Copy link
Contributor

@vanpelt vanpelt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it. Very cool to see a fellow old school JS hacker getting in the mix 🤩

frontend/public/annotator/index.html Show resolved Hide resolved
@vanpelt vanpelt merged commit 34d940e into wandb:main May 20, 2024
1 check passed
@three-water666 three-water666 deleted the patch-1 branch May 21, 2024 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants