Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Sanity example deps and implementation #65744

Merged
merged 1 commit into from
May 16, 2024

Conversation

stipsan
Copy link
Contributor

@stipsan stipsan commented May 14, 2024

  • Uses the new presentationTool.resolve.locations instead of presentationTool.locate API, which doesn't require wrangling rxjs.
  • Sets up the new presentationTool.resolve.mainDocuments API, which automatically opens up the post you're previewing on the left side in the editor on the right side.
  • Removes the sanity-typegen.json config file as sanity typegen now looks for top level app and sanity folders by default.
  • Enables ^ semver ranges for deps again now that our turbopack support is stable, so that we only have to send you PRs when bumping majors or changing the implementation itself.
  • Sets up sanity.config.ts so it's possible to use npx sanity dev for quickly iterating on schemas.

@stipsan stipsan requested review from a team as code owners May 14, 2024 15:33
@stipsan stipsan requested review from molebox and StephDietz and removed request for a team May 14, 2024 15:33
@ijjk ijjk added the examples Issue/PR related to examples label May 14, 2024
@ijjk
Copy link
Member

ijjk commented May 14, 2024

Allow CI Workflow Run

  • approve CI run for commit: 0a65d1d

Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer

Copy link
Member

@samcx samcx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for submitting a PR! Looks good to me.

@samcx samcx merged commit 00e88b8 into vercel:canary May 16, 2024
35 checks passed
panteliselef pushed a commit to panteliselef/next.js that referenced this pull request May 20, 2024
- Uses the new `presentationTool.resolve.locations` instead of
`presentationTool.locate` API, which doesn't require wrangling `rxjs`.
- Sets up the new `presentationTool.resolve.mainDocuments` API, which
automatically opens up the post you're previewing on the left side in
the editor on the right side.
- Removes the `sanity-typegen.json` config file as `sanity typegen` now
looks for top level `app` and `sanity` folders by default.
- Enables `^` semver ranges for deps again now that our turbopack
support is stable, so that we only have to send you PRs when bumping
majors or changing the implementation itself.
- Sets up `sanity.config.ts` so it's possible to use `npx sanity dev`
for quickly iterating on schemas.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
examples Issue/PR related to examples
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants