Conversations: Add "Cache-Control: no-store" to inbox #10866
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #10866 +/- ##
=========================================
Coverage 57.21% 57.21%
Complexity 7635 7635
=========================================
Files 411 411
Lines 46008 46008
=========================================
Hits 26325 26325
Misses 19683 19683 |
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
stale
bot
added
the
Status: Stale
|
Still relevant |
stale
bot
removed
the
Status: Stale
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
stale
bot
added
the
Status: Stale
|
Still relevant |
stale
bot
removed
the
Status: Stale
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This prevents opened conversations from still being shown as "new" when navigating back to the inbox list using the back button. (this issue mostly exists in mobile chrome which seems to cache more aggressively)
This is similar to how back button navigation is handled in category and discussion lists. See:
https://github.com/vanilla/vanilla/search?q=no-store&unscoped_q=no-store