Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Add support for PKCS12 / PFX client certificates for mTLS #2336

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

pietrygamat
Copy link
Contributor

@pietrygamat pietrygamat commented May 18, 2024

Description

This change allows bruno to use client certificates stored in PFX / PKCS12 files in addition to regular PEM cert/key pairs.
Updated the Client Certificate selection in Collection view so that the user can specify if they are using pfx format, in which case the key file becomes unnecessary, and the control disabled. The passphrase field works for both formats.

Axios used by bruno has the support built-in so this change is a rather trivial one, with only the question of UI to solve.

resolves #1889
resolves #1698

Contribution Checklist:

  • The pull request only addresses one issue or adds one feature.
  • The pull request does not introduce any breaking changes
  • I have added screenshots or gifs to help explain the change if applicable.
  • I have read the contribution guidelines.
  • Create an issue and link to the pull request.

Screenshot from 2024-05-18 02-05-06
Screenshot from 2024-05-18 02-04-52

For reference: Postman implementation
Screenshot from 2024-05-18 02-16-20

@pietrygamat pietrygamat force-pushed the feature/client-certificate-p12 branch from 6312a86 to 07d3089 Compare May 20, 2024 19:39
@helloanoop
Copy link
Contributor

Thank you @pietrygamat !

@lohxt1 Lets target this to have it merged for next weeks release.
Assigning it to you.

@pietrygamat pietrygamat force-pushed the feature/client-certificate-p12 branch from 07d3089 to bf4eb21 Compare May 22, 2024 16:13
@thalesog
Copy link

thalesog commented Jun 10, 2024

Guys, can we get this PR merged, please?

@jimbase
Copy link

jimbase commented Jun 10, 2024

+1 :-) I want to present bruno to my colleagues as the better alternative to postman - but I need the change bc of our client certificates environments

@nddipiazza
Copy link

When clicking on the Add certificate button, it says "Successfully added client certificate" but nothing appears in the Client Certificates list

@nddipiazza
Copy link

ignore my last comment.
when updating Bruno on windows using the Exe... the exe does not seem to update gracefully
we had to delete %LocalAppData%\Programs\bruno then run the exe to update. then it worked.

@nddipiazza
Copy link

adding a +1 from community here. this fixed our problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Importing PFX in Client Certificates should not require Key File Question: Using Keystore .p12
6 participants