Fix Notes flash using local state #5469
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Work Detail
Modified the logic of useNotes hook using useState and useEffect.
cashedNotes
retains previously imported data. This allows existing data to remain visible while new data is imported.isLoading
to false.I believe this will prevent the UI from flickering, and it actually fixed the issue when I tested it on my local environment.
Tested in a slow 3G network.
Preview
2024-05-20.2.40.19.mov