Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: edit link in Links field #5447

Merged
merged 1 commit into from
May 22, 2024
Merged

Conversation

thaisguigon
Copy link
Contributor

Closes #5376

@charlesBochet charlesBochet self-assigned this May 17, 2024
@thaisguigon thaisguigon force-pushed the feat/set-link-as-primary branch 2 times, most recently from b3c827d to eb120d2 Compare May 20, 2024 13:09
@thaisguigon thaisguigon force-pushed the feat/edit-link-in-links-field branch from 9b6b6a2 to 20d14b3 Compare May 20, 2024 13:10
@thaisguigon thaisguigon force-pushed the feat/set-link-as-primary branch 2 times, most recently from 5168b62 to 18875ea Compare May 22, 2024 08:15
@thaisguigon thaisguigon force-pushed the feat/edit-link-in-links-field branch 2 times, most recently from 50fc41d to 5207ccc Compare May 22, 2024 08:21
Base automatically changed from feat/set-link-as-primary to main May 22, 2024 08:32
@thaisguigon thaisguigon force-pushed the feat/edit-link-in-links-field branch from 5207ccc to 50009f9 Compare May 22, 2024 08:33
@charlesBochet charlesBochet merged commit e2b48e2 into main May 22, 2024
11 of 12 checks passed
@charlesBochet charlesBochet deleted the feat/edit-link-in-links-field branch May 22, 2024 08:42
Copy link

Fails
🚫

node failed.

Log

�[31mError: �[39m RequestError [HttpError]: Not Found
    at /home/runner/work/twenty/twenty/node_modules/�[4m@octokit�[24m/request/dist-node/index.js:86:21
�[90m    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)�[39m {
  status: �[33m404�[39m,
  response: {
    url: �[32m'https://api.github.com/orgs/twentyhq/teams/core-team/members'�[39m,
    status: �[33m404�[39m,
    headers: {
      �[32m'access-control-allow-origin'�[39m: �[32m'*'�[39m,
      �[32m'access-control-expose-headers'�[39m: �[32m'ETag, Link, Location, Retry-After, X-GitHub-OTP, X-RateLimit-Limit, X-RateLimit-Remaining, X-RateLimit-Used, X-RateLimit-Resource, X-RateLimit-Reset, X-OAuth-Scopes, X-Accepted-OAuth-Scopes, X-Poll-Interval, X-GitHub-Media-Type, X-GitHub-SSO, X-GitHub-Request-Id, Deprecation, Sunset'�[39m,
      connection: �[32m'close'�[39m,
      �[32m'content-encoding'�[39m: �[32m'gzip'�[39m,
      �[32m'content-security-policy'�[39m: �[32m"default-src 'none'"�[39m,
      �[32m'content-type'�[39m: �[32m'application/json; charset=utf-8'�[39m,
      date: �[32m'Wed, 22 May 2024 08:43:08 GMT'�[39m,
      �[32m'referrer-policy'�[39m: �[32m'origin-when-cross-origin, strict-origin-when-cross-origin'�[39m,
      server: �[32m'GitHub.com'�[39m,
      �[32m'strict-transport-security'�[39m: �[32m'max-age=31536000; includeSubdomains; preload'�[39m,
      �[32m'transfer-encoding'�[39m: �[32m'chunked'�[39m,
      vary: �[32m'Accept-Encoding, Accept, X-Requested-With'�[39m,
      �[32m'x-accepted-github-permissions'�[39m: �[32m'members=read'�[39m,
      �[32m'x-content-type-options'�[39m: �[32m'nosniff'�[39m,
      �[32m'x-frame-options'�[39m: �[32m'deny'�[39m,
      �[32m'x-github-api-version-selected'�[39m: �[32m'2022-11-28'�[39m,
      �[32m'x-github-media-type'�[39m: �[32m'github.v3; format=json'�[39m,
      �[32m'x-github-request-id'�[39m: �[32m'088F:62A3F:4D34242:4DC1F20:664DB01C'�[39m,
      �[32m'x-ratelimit-limit'�[39m: �[32m'15000'�[39m,
      �[32m'x-ratelimit-remaining'�[39m: �[32m'14720'�[39m,
      �[32m'x-ratelimit-reset'�[39m: �[32m'1716369341'�[39m,
      �[32m'x-ratelimit-resource'�[39m: �[32m'core'�[39m,
      �[32m'x-ratelimit-used'�[39m: �[32m'280'�[39m,
      �[32m'x-xss-protection'�[39m: �[32m'0'�[39m
    },
    data: {
      message: �[32m'Not Found'�[39m,
      documentation_url: �[32m'https://docs.github.com/rest/teams/members#list-team-members'�[39m
    }
  },
  request: {
    method: �[32m'GET'�[39m,
    url: �[32m'https://api.github.com/orgs/twentyhq/teams/core-team/members'�[39m,
    headers: {
      accept: �[32m'application/vnd.github.v3+json'�[39m,
      �[32m'user-agent'�[39m: �[32m'octokit-rest.js/18.12.0 octokit-core.js/3.6.0 Node.js/18.20.2 (linux; x64)'�[39m,
      authorization: �[32m'token [REDACTED]'�[39m
    },
    request: { hook: �[36m[Function: bound bound register]�[39m }
  }
}
danger-results://tmp/danger-results-ac464648.json

Generated by 🚫 dangerJS against 50009f9

Weiko pushed a commit that referenced this pull request May 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Multi-links field] Edit link
2 participants