Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: reset default value on field type switch in Settings/Data Model … #5436

Merged
merged 1 commit into from
May 22, 2024

Conversation

thaisguigon
Copy link
Contributor

…field form

Closes #5412

Copy link

github-actions bot commented May 16, 2024

Fails
🚫

node failed.

Log

�[31mError: �[39m RequestError [HttpError]: Not Found
    at /home/runner/work/twenty/twenty/node_modules/�[4m@octokit�[24m/request/dist-node/index.js:86:21
�[90m    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)�[39m {
  status: �[33m404�[39m,
  response: {
    url: �[32m'https://api.github.com/orgs/twentyhq/teams/core-team/members'�[39m,
    status: �[33m404�[39m,
    headers: {
      �[32m'access-control-allow-origin'�[39m: �[32m'*'�[39m,
      �[32m'access-control-expose-headers'�[39m: �[32m'ETag, Link, Location, Retry-After, X-GitHub-OTP, X-RateLimit-Limit, X-RateLimit-Remaining, X-RateLimit-Used, X-RateLimit-Resource, X-RateLimit-Reset, X-OAuth-Scopes, X-Accepted-OAuth-Scopes, X-Poll-Interval, X-GitHub-Media-Type, X-GitHub-SSO, X-GitHub-Request-Id, Deprecation, Sunset'�[39m,
      connection: �[32m'close'�[39m,
      �[32m'content-encoding'�[39m: �[32m'gzip'�[39m,
      �[32m'content-security-policy'�[39m: �[32m"default-src 'none'"�[39m,
      �[32m'content-type'�[39m: �[32m'application/json; charset=utf-8'�[39m,
      date: �[32m'Wed, 22 May 2024 07:54:03 GMT'�[39m,
      �[32m'referrer-policy'�[39m: �[32m'origin-when-cross-origin, strict-origin-when-cross-origin'�[39m,
      server: �[32m'GitHub.com'�[39m,
      �[32m'strict-transport-security'�[39m: �[32m'max-age=31536000; includeSubdomains; preload'�[39m,
      �[32m'transfer-encoding'�[39m: �[32m'chunked'�[39m,
      vary: �[32m'Accept-Encoding, Accept, X-Requested-With'�[39m,
      �[32m'x-accepted-github-permissions'�[39m: �[32m'members=read'�[39m,
      �[32m'x-content-type-options'�[39m: �[32m'nosniff'�[39m,
      �[32m'x-frame-options'�[39m: �[32m'deny'�[39m,
      �[32m'x-github-api-version-selected'�[39m: �[32m'2022-11-28'�[39m,
      �[32m'x-github-media-type'�[39m: �[32m'github.v3; format=json'�[39m,
      �[32m'x-github-request-id'�[39m: �[32m'606F:2EAF65:6ED1803:C25B4D0:664DA49B'�[39m,
      �[32m'x-ratelimit-limit'�[39m: �[32m'15000'�[39m,
      �[32m'x-ratelimit-remaining'�[39m: �[32m'14764'�[39m,
      �[32m'x-ratelimit-reset'�[39m: �[32m'1716365259'�[39m,
      �[32m'x-ratelimit-resource'�[39m: �[32m'core'�[39m,
      �[32m'x-ratelimit-used'�[39m: �[32m'236'�[39m,
      �[32m'x-xss-protection'�[39m: �[32m'0'�[39m
    },
    data: {
      message: �[32m'Not Found'�[39m,
      documentation_url: �[32m'https://docs.github.com/rest/teams/members#list-team-members'�[39m
    }
  },
  request: {
    method: �[32m'GET'�[39m,
    url: �[32m'https://api.github.com/orgs/twentyhq/teams/core-team/members'�[39m,
    headers: {
      accept: �[32m'application/vnd.github.v3+json'�[39m,
      �[32m'user-agent'�[39m: �[32m'octokit-rest.js/18.12.0 octokit-core.js/3.6.0 Node.js/18.20.2 (linux; x64)'�[39m,
      authorization: �[32m'token [REDACTED]'�[39m
    },
    request: { hook: �[36m[Function: bound bound register]�[39m }
  }
}
danger-results://tmp/danger-results-16aa727f.json

Generated by 🚫 dangerJS against 830c35e

@thaisguigon thaisguigon force-pushed the fix/reset-field-form-on-type-change branch from 6e2a3c1 to 830c35e Compare May 20, 2024 13:12

const isEditMode = isDefined(fieldMetadataItem?.defaultValue);
const initialValue = fieldMetadataItem?.defaultValue ?? true;

// Reset defaultValue on mount, so it doesn't conflict with other field types.
useEffect(() => {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ideally we would like to avoid these useEffect behaviors.
why not resetting the defaultValue when we pick a new type in the type dropdown?

@charlesBochet charlesBochet merged commit 944b2b0 into main May 22, 2024
11 of 12 checks passed
@charlesBochet charlesBochet deleted the fix/reset-field-form-on-type-change branch May 22, 2024 07:53
charlesBochet pushed a commit that referenced this pull request May 24, 2024
Weiko pushed a commit that referenced this pull request May 31, 2024
Weiko pushed a commit that referenced this pull request May 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants