-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: reset default value on field type switch in Settings/Data Model … #5436
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Log
|
…field form Closes #5412
thaisguigon
force-pushed
the
fix/reset-field-form-on-type-change
branch
from
May 20, 2024 13:12
6e2a3c1
to
830c35e
Compare
charlesBochet
approved these changes
May 22, 2024
|
||
const isEditMode = isDefined(fieldMetadataItem?.defaultValue); | ||
const initialValue = fieldMetadataItem?.defaultValue ?? true; | ||
|
||
// Reset defaultValue on mount, so it doesn't conflict with other field types. | ||
useEffect(() => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ideally we would like to avoid these useEffect behaviors.
why not resetting the defaultValue when we pick a new type in the type dropdown?
charlesBochet
pushed a commit
that referenced
this pull request
May 24, 2024
Related issue: #5412 See #5436 (comment) for context.
Weiko
pushed a commit
that referenced
this pull request
May 31, 2024
Related issue: #5412 See #5436 (comment) for context.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…field form
Closes #5412