Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix notification filters behaving weirdly #4437

Merged
merged 1 commit into from
May 22, 2024
Merged

Conversation

connyduck
Copy link
Collaborator

@connyduck connyduck commented May 10, 2024

This does four things

  • set enablePlaceholders = false on PagingConfigs to avoid Paging Data that contains null placeholders, we don't want them (everywhere, not just in notifications)
  • make sure NotificationsPagingAdapter does not crash when it encounters a null placeholder
  • makes sure the notifications refresh correctly when the filters change
  • the filters are now also respected when loading a gap

closes #4433

@connyduck connyduck requested review from Tak, mcclure and charlag May 10, 2024 15:12
@connyduck
Copy link
Collaborator Author

meh now it sometimes makes more network requests than necessary

@mcclure
Copy link
Collaborator

mcclure commented May 12, 2024

I've been using this for a couple days now and I haven't noticed the issues from #4433 recurring. Will continue testing.

@connyduck connyduck merged commit f0a9c8b into develop May 22, 2024
3 checks passed
@connyduck connyduck deleted the fix_notification_filter branch May 22, 2024 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tusky notification-refactor branch got confused about filters, then crashed
3 participants