-
-
Notifications
You must be signed in to change notification settings - Fork 505
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add capability to specify variable entitlements #6293
Conversation
fix for tuist#5940 Currently, Xcode don't have a good support for variables inside an entitlement value, causing an issue in projects with multiple environments and appclip
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for contributing this @lucasmpaim
@all-contributors add @lucasmpaim for code |
I've put up a pull request to add @lucasmpaim! π |
also add a new unit test to test variable set by string literal
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the updates @lucasmpaim
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just two minor comments, afterwards, we can merge π
Currently, Xcode don't have a good support for variables inside an entitlement value, causing an issue in projects with multiple environments and appclip
Resolves #5940
For some reason, Xcode are not solving variables defined in xcconfig on the entitlements file and for appclips the linter are forcing us to provide one file:
So this PR provides a capability to provide this file using a xcconfig settings, changing the
CODE_SIGN_ENTITLEMENTS
variable in a dynamic way.Short description π
How to test the changes locally π§
Contributor checklist β
mise run lint:fix
Reviewer checklist β
changelog:added
,changelog:fixed
, orchangelog:changed
, and the title is usable as a changelog entry