Fix TypeScript inclusion in tsconfig.json for cli-v3 init
#1105
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1017
✅ Checklist
Testing
tsconfig.json
file does not contain an explicitinclude
directive.pnpm exec triggerdev init
.trigger.config.ts
file is not included in theinclude
tsconfig directive.include
directive to thetsconfig.json
file.include
directive is added, runpnpm exec triggerdev init
again.trigger.config.ts
is included in theinclude
directive tsconfig, as it should be based on the presence of the include directive.Changelog
This pull request addresses an issue specific to the
cli-v3 init
where TypeScript files were mistakenly included in the project directory when no include directive was present intsconfig.json
. Previously, the cli init addedtrigger.config.ts
to the inclusion list by default, resulting in TypeScript compilation errors for other files within the project.To resolve this issue, the proposed fix ensures that
trigger.config.ts
is only added to the inclusion list if there's an existing include directive present intsconfig.json
. This prevents unintended TypeScript compilation errors for other files and maintains the expected behavior of the TypeScript compiler.💯