Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

yt-dlp: update page #12580

Merged
merged 25 commits into from
Jun 4, 2024
Merged

yt-dlp: update page #12580

merged 25 commits into from
Jun 4, 2024

Conversation

thrila
Copy link
Contributor

@thrila thrila commented Mar 30, 2024

  • The page(s) are in the correct platform directories: common, linux, osx, windows, sunos, android, etc.
  • The page(s) have at most 8 examples.
  • The page description(s) have links to documentation or a homepage.
  • The page(s) follow the content guidelines.
  • The PR title conforms to the recommended templates.
  • Version of the command being documented (if known):

@github-actions github-actions bot added the page edit Changes to an existing page(s). label Mar 30, 2024
@thrila
Copy link
Contributor Author

thrila commented Mar 30, 2024

@kbdharun please confirm

CleanMachine1
CleanMachine1 requested changes Mar 30, 2024
View reviewed changes
pages/common/yt-dlp.md Outdated Show resolved Hide resolved
pages/common/yt-dlp.md Outdated Show resolved Hide resolved
pages/common/yt-dlp.md Outdated Show resolved Hide resolved
pages/common/yt-dlp.md Outdated Show resolved Hide resolved
@thrila
Copy link
Contributor Author

thrila commented Mar 30, 2024

Thanks for the correction

fazlearefin
fazlearefin reviewed Mar 30, 2024
View reviewed changes
pages/common/yt-dlp.md Outdated Show resolved Hide resolved
Magrid0
Magrid0 previously approved these changes Mar 30, 2024
View reviewed changes
Copy link
Member

@Magrid0 Magrid0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@kbdharun kbdharun changed the title chore: add page for yt-dlp yt-dlp: update page Mar 30, 2024
kbdharun
kbdharun reviewed Mar 30, 2024
View reviewed changes
pages/common/yt-dlp.md Outdated Show resolved Hide resolved
@CleanMachine1
Copy link
Member

You did not make any changes following my comments, and then proceeded to close them, saying they have been resolved.

Please actually respond to them appropriately.

CleanMachine1
CleanMachine1 previously requested changes Apr 2, 2024
View reviewed changes
Copy link
Member

@CleanMachine1 CleanMachine1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please do not approve before actually reading and commenting on my original feedback.

@thrila
Copy link
Contributor Author

thrila commented Apr 2, 2024

my apologies started using github mobile seems im yet to fully understand it , still i thought the change you made was changing the placeholder url to the keyword url

@CleanMachine1
Copy link
Member

Do you plan on changing anything suggested, or should we close this PR?

@thrila
Copy link
Contributor Author

thrila commented Apr 13, 2024

Do you plan on changing anything suggested, or should we close this PR?

yeah lemme do it now kinda forgot

@thrila thrila closed this Apr 13, 2024
@thrila thrila reopened this Apr 13, 2024
@thrila
Copy link
Contributor Author

thrila commented Apr 13, 2024

Do you plan on changing anything suggested, or should we close this PR?

Hi finished do you mind checking?

@CleanMachine1
Copy link
Member

That commit has nothing in it, did you not push your changes?

@thrila
Copy link
Contributor Author

thrila commented Apr 17, 2024

That commit has nothing in it, did you not push your changes?

Seems i didnt my bad haven't really contributed to a project before Thanks for the patience

vitorhcl
vitorhcl previously requested changes Apr 23, 2024
View reviewed changes
pages/common/yt-dlp.md Outdated Show resolved Hide resolved
@thrila
Copy link
Contributor Author

thrila commented May 5, 2024

Any more corrections?

@sebastiaanspeck sebastiaanspeck mentioned this pull request May 26, 2024
Closed
5 tasks
thrila and others added 2 commits May 27, 2024 08:58
@thrila
Copy link
Contributor Author

thrila commented May 27, 2024

done !! please check to make sure it's the format we want

kbdharun
kbdharun reviewed May 27, 2024
View reviewed changes
Copy link
Member

@kbdharun kbdharun left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution. I have some suggestions for this page. After this the PR is GTG.

pages/common/yt-dlp.md Outdated Show resolved Hide resolved
pages/common/yt-dlp.md Outdated Show resolved Hide resolved
pages/common/yt-dlp.md Outdated Show resolved Hide resolved
pages/common/yt-dlp.md Outdated Show resolved Hide resolved
pages/common/yt-dlp.md Outdated Show resolved Hide resolved
pages/common/yt-dlp.md Outdated Show resolved Hide resolved
@thrila
Copy link
Contributor Author

thrila commented May 27, 2024

Thanks for your contribution. I have some suggestions for this page. After this the PR is GTG.

Well ok I'll make the changes

thrila and others added 7 commits May 27, 2024 17:21
@thrila @kbdharun
Update pages/common/yt-dlp.md
ddb8a24 
Co-authored-by: K.B.Dharun Krishna <kbdharunkrishna@gmail.com>
@thrila @kbdharun
Update pages/common/yt-dlp.md
4ea2b36 
Co-authored-by: K.B.Dharun Krishna <kbdharunkrishna@gmail.com>
@thrila @kbdharun
Update pages/common/yt-dlp.md
31366a1 
Co-authored-by: K.B.Dharun Krishna <kbdharunkrishna@gmail.com>
@thrila @kbdharun
Update pages/common/yt-dlp.md
4268b31 
Co-authored-by: K.B.Dharun Krishna <kbdharunkrishna@gmail.com>
@thrila @kbdharun
Update pages/common/yt-dlp.md
166eb90 
Co-authored-by: K.B.Dharun Krishna <kbdharunkrishna@gmail.com>
@thrila @kbdharun
Update pages/common/yt-dlp.md
0188dd2 
Co-authored-by: K.B.Dharun Krishna <kbdharunkrishna@gmail.com>
@thrila
Merge branch 'main' into main
bcf4bf6
@thrila
Copy link
Contributor Author

thrila commented May 27, 2024

can some check to connfirm that the changes were indeed applied?

kbdharun
kbdharun approved these changes May 27, 2024
View reviewed changes
Copy link
Member

@kbdharun kbdharun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, as the other maintainers say these links must be updated to align with their example description.

pages/common/yt-dlp.md Outdated Show resolved Hide resolved
pages/common/yt-dlp.md Outdated Show resolved Hide resolved
@CleanMachine1 CleanMachine1 removed their request for review May 28, 2024 20:10
@spageektti
Copy link
Member

@thrila can you please check the suggestions?

spageektti and others added 2 commits June 4, 2024 08:39
@spageektti @kbdharun
yt-dlp: fix placeholder url
082092d 
Co-authored-by: K.B.Dharun Krishna <kbdharunkrishna@gmail.com>
@spageektti
remove example
d8e4ebd
kbdharun
kbdharun reviewed Jun 4, 2024
View reviewed changes
pages/common/yt-dlp.md Outdated Show resolved Hide resolved
@kbdharun kbdharun dismissed stale reviews from vitorhcl and CleanMachine1 June 4, 2024 08:05

Outdated

@kbdharun kbdharun merged commit fde9b62 into tldr-pages:main Jun 4, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fazlearefin fazlearefin fazlearefin left review comments

@sebastiaanspeck sebastiaanspeck sebastiaanspeck left review comments

@CleanMachine1 CleanMachine1 CleanMachine1 left review comments

@kbdharun kbdharun kbdharun approved these changes

@spageektti spageektti spageektti approved these changes

@vitorhcl vitorhcl vitorhcl left review comments

@Magrid0 Magrid0 Awaiting requested review from Magrid0

Assignees
No one assigned
Labels
page edit Changes to an existing page(s).
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@thrila @CleanMachine1 @vitorhcl @kbdharun @sebastiaanspeck @spageektti @fazlearefin @Magrid0