Add RDB dump #81
Open
Add RDB dump #81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Morgan279 <wancheng.long@pingcap.com>
|
|
Signed-off-by: Morgan279 <wancheng.long@pingcap.com>
src/rdb.rs
Outdated
| .create(true) | ||
| .truncate(true) | ||
| .write(true) | ||
| .open("dump.rdb") |
There was a problem hiding this comment.
It's better to make file name configurable.
|
We should make it possible to disable this command from configuration file. Like rename-command SAVE b840fc02d524045429941cc15f59e41cb7be6c52 But that can be done in a separate PR. Just bear it in mind. |
Signed-off-by: yongman <yming0221@gmail.com>
Signed-off-by: Morgan279 <wancheng.long@pingcap.com>
Signed-off-by: Morgan279 <wancheng.long@pingcap.com>
|
Get it. |
|
Compatibility tests (redis RDB recovery) under base case in all data types and chaotic data distribution (generated by build-redis-data) have been passed. |
Signed-off-by: Morgan279 <wancheng.long@pingcap.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Morgan279 wancheng.long@pingcap.com