Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix confusion between killer and prey #32868

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Fix confusion between killer and prey #32868

wants to merge 3 commits into from
+502 −502

Conversation

keszybz
Copy link
Member

@keszybz keszybz commented May 16, 2024 •
edited by github-actions bot

"who" is the entity doing the killing, "whom" is the target. Follow-up for 4ccde41.

@github-actions github-actions bot added login documentation tests please-review PR is ready for (re-)review by a maintainer labels May 16, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented May 16, 2024 •
edited

Note

We had successfully released a new major release. We are no longer in a development freeze phase.
We will try our best to get back to your PR as soon as possible. Thank you for your patience.

YHNdnzj
YHNdnzj approved these changes May 16, 2024
View reviewed changes
src/login/logind-session.h Outdated Show resolved Hide resolved
src/machine/machine.h Outdated Show resolved Hide resolved
src/core/kill.h Outdated Show resolved Hide resolved
@YHNdnzj YHNdnzj added machine pid1 good-to-merge/with-minor-suggestions and removed please-review PR is ready for (re-)review by a maintainer labels May 16, 2024
@keszybz keszybz added please-review PR is ready for (re-)review by a maintainer and removed good-to-merge/with-minor-suggestions labels May 17, 2024
@yuwata
Copy link
Member

yuwata commented Jun 12, 2024

I don't see any suggestions.

yeah, the same as the other PR. Sorry for the confusion. LGTM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bluca bluca bluca approved these changes

@YHNdnzj YHNdnzj YHNdnzj approved these changes

Assignees
No one assigned
Labels
documentation good-to-merge/waiting-for-ci 👍 PR is good to merge, but CI hasn't passed at time of review. Please merge if you see CI has passed login machine pid1 tree-wide util-lib
Milestone
v257
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@keszybz @poettering @yuwata @bluca @YHNdnzj