Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

analyze: add new verb "smbios11" for listing passed smbios type #11 strings #32810

Merged
merged 3 commits into from
Jun 12, 2024
Merged

analyze: add new verb "smbios11" for listing passed smbios type #11 strings #32810

merged 3 commits into from
Jun 12, 2024
+182 −27

Conversation

poettering
Copy link
Member

@poettering poettering commented May 14, 2024 •
edited by github-actions bot

There's no nice way to query this otherwise with default distro tools

@poettering poettering added this to the v257 milestone May 14, 2024
@dnicolodi
Copy link

Would it make sense to have the tool optionally emit machine parsable output (ie omit the trailing log message)?

@poettering
Copy link
Member Author

Would it make sense to have the tool optionally emit machine parsable output (ie omit the trailing log message)?

that goes to stderr anyway (unlike the strings themselves) and you can always use SYSTEMD_LOG_TARGET=null...

@github-actions github-actions bot added documentation build-system util-lib meson please-review PR is ready for (re-)review by a maintainer labels May 14, 2024
@dnicolodi
Copy link

Right. I didn't pay attention to how the command is implemented, I just inferred from the documentation. Thanks!

@github-actions GitHub Actions
Copy link

github-actions bot commented May 14, 2024 •
edited

Note

We had successfully released a new major release. We are no longer in a development freeze phase.
We will try our best to get back to your PR as soon as possible. Thank you for your patience.

yuwata
yuwata reviewed May 14, 2024
View reviewed changes
src/shared/smbios11.c Outdated Show resolved Hide resolved
src/analyze/analyze-smbios11.c Outdated Show resolved Hide resolved
src/analyze/analyze-smbios11.c Show resolved Hide resolved
@poettering
Copy link
Member Author

new version pushed, ptal

yuwata
yuwata approved these changes May 22, 2024
View reviewed changes
Copy link
Member

@yuwata yuwata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Please add simple coverage tests for the new command.

@poettering
Copy link
Member Author

Right. I didn't pay attention to how the command is implemented, I just inferred from the documentation. Thanks!

btw, the message is now also suppressed if you add "-q" or "--quiet" to the cmdline

@poettering
Copy link
Member Author

Please add simple coverage tests for the new command.

done

@github-actions github-actions bot added the tests label May 23, 2024
@poettering
core: split out smbios type 11 reader into src/shared/smbios11.[ch]
bfb374e
@poettering
analyze: add verb for dumping SMBIOS Type systemd#11 data
8c5045f 
I find myself wanting to check this data with a quick command, and
browsing through /sys/ manually getting binary data sucks. Hence let's
do add a nice little analysis tool.
@poettering
update TODO
99db1c9
@poettering poettering added good-to-merge/waiting-for-ci 👍 PR is good to merge, but CI hasn't passed at time of review. Please merge if you see CI has passed and removed good-to-merge/after-next-release labels Jun 12, 2024
@poettering poettering merged commit df51530 into systemd:main Jun 12, 2024
42 of 49 checks passed
@github-actions github-actions bot removed the good-to-merge/waiting-for-ci 👍 PR is good to merge, but CI hasn't passed at time of review. Please merge if you see CI has passed label Jun 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yuwata yuwata yuwata approved these changes

@YHNdnzj YHNdnzj YHNdnzj left review comments

Assignees
No one assigned
Labels
analyze build-system documentation meson new-feature tests util-lib
Milestone
v257
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@poettering @dnicolodi @yuwata @YHNdnzj