bootctl: add --random-seed=yes/no #32802
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuwata
reviewed
May 14, 2024
bluca
reviewed
May 14, 2024
bluca
reviewed
May 14, 2024
bluca
reviewed
May 14, 2024
github-actions
bot
added
documentation
please-review
|
Note We had successfully released a new major release. We are no longer in a development freeze phase. |
bluca
added
good-to-merge/after-next-release
good-to-merge/with-minor-suggestions
and removed
please-review
lnussel
force-pushed
the
bootctl
branch
2 times, most recently
from
9106030
to
41b759f
Compare
bluca
approved these changes
May 14, 2024
|
lgtm, too |
yuwata
approved these changes
Jun 12, 2024
| @@ -334,6 +339,14 @@ static int parse_argv(int argc, char *argv[]) { | |||
| arg_touch_variables = false; | |||
| break; | |||
|
|
|||
| case ARG_RANDOM_SEED: | |||
| r = parse_boolean_argument("--random-seed=", optarg, NULL); | |||
There was a problem hiding this comment.
Why not to pass arg_install_random_seed here?
yuwata
added
good-to-merge/with-minor-suggestions
and removed
good-to-merge/after-next-release
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.