Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Environment Import & Export API #201

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Add Environment Import & Export API #201

wants to merge 6 commits into from

Conversation

svix-frank
Copy link
Contributor

@svix-frank svix-frank commented Jan 14, 2022

No description provided.

@svix-frank svix-frank requested review from tasn, svix-liam and a team January 14, 2022 02:49
@svix-frank svix-frank marked this pull request as ready for review January 14, 2022 14:53
svix-liam
svix-liam previously approved these changes Jan 14, 2022
Copy link
Contributor

@svix-liam svix-liam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@svix-frank
Copy link
Contributor Author

LGTM

What do you think about the naming for python and java?

@svix-liam
Copy link
Contributor

I don't think there's a better option. Only other question: do we want to rename organization in libs to environment to be consistent with the UI?

Copy link
Member

@tasn tasn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to be renamed to environment (per the API).

@svix-frank svix-frank changed the title Add Org Import & Export API Add Environment Import & Export API Feb 3, 2022
@svix-frank svix-frank requested review from tasn, svix-liam and svix-stephanie and removed request for svix-liam February 3, 2022 22:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants