Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom error boundary #25946

Merged
merged 5 commits into from May 13, 2024
Merged

Custom error boundary #25946

merged 5 commits into from May 13, 2024

Conversation

joshenlim
Copy link
Member

@joshenlim joshenlim commented May 9, 2024

Implement a custom error boundary that will notify Sentry if a full page crash occurs in an effort to ensure that our dashboard (ideally) never runs into that scenario, and that we take a pro-active stance towards such instances.

This also allows us to create a custom error page that's slightly more helpful than next.js's default where we add a button to let users report the issue via support, with the subject and message all filled out. We'll definitely relook at this one to make it prettier as well
image

@joshenlim joshenlim requested a review from a team as a code owner May 9, 2024 09:52
Copy link

vercel bot commented May 9, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
database-new 🔄 Building (Inspect) Visit Preview 💬 Add feedback May 10, 2024 7:42am
studio-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 10, 2024 7:42am
4 Ignored Deployments
Name Status Preview Comments Updated (UTC)
docs ⬜️ Ignored (Inspect) Visit Preview May 10, 2024 7:42am
studio ⬜️ Ignored (Inspect) Visit Preview May 10, 2024 7:42am
studio-self-hosted ⬜️ Ignored (Inspect) Visit Preview May 10, 2024 7:42am
zone-www-dot-com ⬜️ Ignored (Inspect) Visit Preview May 10, 2024 7:42am

Copy link

supabase bot commented May 9, 2024

No changes detected in supabase directory.
This pull request has been ignored for the connected project xguihxuzqibwxjnimxev due to its connection settings.
Go to Project Integrations Settings ↗︎ in order to change this behavior.


Branching Preview Branches by Supabase.
Learn more about Supabase for Git ↗︎.

@joshenlim joshenlim marked this pull request as draft May 9, 2024 09:52
Copy link
Member

@alaister alaister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🔥

apps/studio/components/ui/ErrorBoundaryState.tsx Outdated Show resolved Hide resolved
Co-authored-by: Alaister Young <alaister@users.noreply.github.com>
@joshenlim joshenlim merged commit a72220e into master May 13, 2024
14 checks passed
@joshenlim joshenlim deleted the chore/custom-error-boundary branch May 13, 2024 05:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants