Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: revert renaming vector to pgvector on the client #25911

Merged
merged 6 commits into from May 10, 2024

Conversation

w3b6x9
Copy link
Member

@w3b6x9 w3b6x9 commented May 9, 2024

I have read the CONTRIBUTING.md file.

YES

What kind of change does this PR introduce?

fix

What is the new behavior?

  • Revert changes made to the vector extension name.
  • Add to pgvector docs that the extension name is vector.
  • Add a link to pgvector docs from Studio > pgvector extension card.

Note

Do not run formatter on docs.

@w3b6x9 w3b6x9 requested a review from a team as a code owner May 9, 2024 01:35
Copy link

vercel bot commented May 9, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 10, 2024 3:52am
studio-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 10, 2024 3:52am
zone-www-dot-com ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 10, 2024 3:52am
3 Ignored Deployments
Name Status Preview Comments Updated (UTC)
database-new ⬜️ Ignored (Inspect) May 10, 2024 3:52am
studio ⬜️ Ignored (Inspect) Visit Preview May 10, 2024 3:52am
studio-self-hosted ⬜️ Ignored (Inspect) Visit Preview May 10, 2024 3:52am

Copy link

supabase bot commented May 9, 2024

No changes detected in supabase directory.
This pull request has been ignored for the connected project xguihxuzqibwxjnimxev due to its connection settings.
Go to Project Integrations Settings ↗︎ in order to change this behavior.


Branching Preview Branches by Supabase.
Learn more about Supabase for Git ↗︎.

@@ -396,7 +396,7 @@
"link": "/guides/database/extensions/uuid-ossp"
},
{
"name": "pgvector",
"name": "vector",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this fixes the issue that the vector extension card link wasn't being displayed.

@@ -6,6 +6,10 @@ description: 'pgvector: a PostgreSQL extension for storing embeddings and perfor

[pgvector](https://github.com/pgvector/pgvector/) is a PostgreSQL extension for vector similarity search. It can also be used for storing [embeddings](https://supabase.com/blog/openai-embeddings-postgres-vector).

<Admonition type="note">
The name of pgvector's Postgres extension is [vector](https://github.com/pgvector/pgvector/blob/258eaf58fdaff1843617ff59ea855e0768243fe9/README.md?plain=1#L64).
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gregnr @charislam just making sure that users are aware the actual name is vector since there was confusion in support tickets, etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants