Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: docs ai warning removal #23427

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

Hallidayo
Copy link
Contributor

I have read the CONTRIBUTING.md file.

YES

What kind of change does this PR introduce?

Feature - Supabase Docs - Ask AI

What is the current behavior?

Their is an alert which appears which tells the user about the ai being experimental. This makes the page of the window really small.

What is the new behavior?

Experimental button is now a tooltip and the warning is removed:

Screen.Recording.2024-04-29.at.22.52.26.mov

Additional context

Closes #22714

Copy link

vercel bot commented Apr 29, 2024

@Hallidayo is attempting to deploy a commit to the Supabase Team on Vercel.

A member of the Team first needs to authorize it.

Copy link
Contributor

@charislam charislam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Hallidayo! I'd rather keep a very explicit, in-your-face warning message about this. I think it's important to prompt users to take a pause for reflection before running anything against their database, and the tooltip is easy to ignore.

There's probably room to expand the height of the entire dialog on most screens so you have more reading space despite the disclaimer, perhaps we can do that instead?

@Hallidayo
Copy link
Contributor Author

Hi @charislam - Just reverted the original changes and increased the window a little as well:

Screenshot 2024-05-01 at 22 05 51

@@ -85,7 +85,7 @@ const CommandMenu = () => {
currentPage === COMMAND_ROUTES.AI ||
currentPage === COMMAND_ROUTES.GENERATE_SQL
? 'min(600px, 50vh)'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Hallidayo! Really appreciate you going along with the changes 😄 IIRC it is this line actually that sets the height on the AI pages (it's already bigger than the usual but I guess we can increase it even further)

@Hallidayo
Copy link
Contributor Author

Hi @charislam - Thanks for having a look at this, I've just increase the content height a little as well

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ask AI getting unusable. Why popup so small and hide output?
2 participants