Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Broken Email Links Behind Proxy #1571

Open
wants to merge 18 commits into
base: master
Choose a base branch
from

Conversation

nickmitchko
Copy link

What kind of change does this PR introduce?

Fixes #1228

What is the current behavior?

supabase/auth behind a proxy with incorrect or internal-external X-Forwarded headers cause incorrect email account links

What is the new behavior?

  • Adds new environment variable API_FORCE_EXTERNAL_URL=[true | false] to force the API_EXTERNAL_URL to remain unchained. This new variable is turned off by default. Users reliant on the current (slightly broken) behavior have no changes.

Additional context

Total lines changed: 3

Add `API_FORCE_EXTERNAL_URL` to fix login links
Added `API_FORCE_EXTERNAL_URL` to force the auth client to use the external base url when constructing URLs.
@nickmitchko nickmitchko requested a review from a team as a code owner May 5, 2024 02:32
@nickmitchko nickmitchko changed the title Fix Broken Email Links behind Fix Broken Email Links Behind Proxy May 5, 2024
@nickmitchko
Copy link
Author

hello👋? Anyone....

@Obeyed
Copy link

Obeyed commented May 23, 2024

@hf Do you know why this PR hasn't been reviewed / merged yet? I believe this makes the changes as you proposed in the open issue by adding a new config variable. What can be done to to complete this?

@Obeyed
Copy link

Obeyed commented May 29, 2024

@kangmingtay not sure who to ping on this. Are you perhaps able to assist on this PR? Any input / review would be great.

I believe the solution here is what hf proposed on the original issue: #1228 (comment)

@tonven
Copy link

tonven commented May 29, 2024

Any news on this?

@nickmitchko
Copy link
Author

nickmitchko commented May 29, 2024

Re: all interested, I'll continue to merge and keep up to date my feature repo based on main until it comes upstream to this repo.

Update: CI in my repo is running and follows the releases here to https://hub.docker.com/repository/docker/nickmitchko/gotrue/tags

If you need an SBOM, please build your own image.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Broken Invitation Links - http://kong is the domain
3 participants