feat(main-nav): Main nav refactoring, change links order #20275
Merged
+77
−93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simotae14
added
source: core:admin
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
joshuaellis
added
the
flag: don't merge
|
We're gonna look for a better, more complete & extensible way to manage all this. |
|
Size Change: -14 B (0%) Total Size: 2.52 MB
ℹ️ View Unchanged
|
I find this quite confusing, are you using the value to on all MenuItems? or just Plugins? IMO it should be all of them for clarity, which then feels like we should just have the items number 0-X, if you don't specify it gets rendered where it would normally? If you set the CM plugin to position Maybe i've misunderstood you and this is what you've implemented though? |
… into feat/main-nav-change-order
|
You are right, my previous solution was a little bit confusing We are sorting ALL the menu items (not just the plugins ), and the logic is this one
Let me know if it seems better now, thanks |
joshuaellis
requested changes
May 10, 2024
Comment on lines
+41
to
+43
| const NavLinkBadgeLock = styled(NavLink.Badge)` | ||
| background-color: transparent; | ||
| `; |
There was a problem hiding this comment.
You should be able to inline this by passing the backgroundColor prop?
There was a problem hiding this comment.
transparent is not in the possible backgroundColor for the Badge component, I have a type error
There was a problem hiding this comment.
does it work though? cause if so, we can fix the type 🤔
joshuaellis
approved these changes
May 10, 2024
joshuaellis
added
flag: documentation
|
@simotae14 can you double check if the docs need an update? I think we document adding plugin links quite well, and this is very valuable to individuals! |
|
Yeah I suppose they need an update, I am gonna talk about it with Piwi on Monday |
|
We need to add the position parameter here https://docs.strapi.io/dev-docs/api/plugins/admin-panel-api#menu-api |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
It changes the main nav links order based on the specifications on the figma file
I added a position property, which is a numeric and can help us to reorder the plugins.
The links in the main nav are all sorted by position starting from 0 to the last one, the links with the same position number are sorted by link label
If you don't specify the link position then its position is in the middle of the main nav, before the plugin list
Why is it needed?
To give more visibility to the most used links
How to test it?
Just check the new main nav and check the figma file (you can find it in the jira ticket)
Related issue(s)/PR(s)
CS-768