chore(content-releases): releases migration to v5 #20259
Draft
+920
−1,184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* chore: migrate bulkDelete to v5 * chore: change findLocales type to accept strings array * fix: docs prettier styles * chore: remove console.log
…into v5/bulk-publish-unpublish
Feranchz
added
pr: chore
Feranchz
requested review from
simotae14,
madhurisandbhor,
remidej,
Marc-Roig and
markkaylor
Marc-Roig
reviewed
May 3, 2024
| meta: { | ||
| count: actions.count, | ||
| target_type: contentTypeUid, | ||
| target_id: entryId, |
There was a problem hiding this comment.
is the entry id the one stored in the releases actions content type?
There might be a scenario where a document draft is discarded (deleted) and regenerated with a new entry id one.
Would that be an issue?
There was a problem hiding this comment.
That's a good point and probably is going to be a problem 🤔
I'm using the entryId because I think polymorphic relations with documentId are not implemented yet, right? So I don't see a solution 🤔
There was a problem hiding this comment.
we might need to find alternatives, relations will allways be stored using entry ids, it's just that we expose docId relations to make things consistent on the api.
I guess, at the moment, discarding a draft would result in removing that one from the release 🤔
There was a problem hiding this comment.
At the moment, how do you handle entries being deleted? do you have a db lifecycle that checks for those and removes them from the releases?
There was a problem hiding this comment.
Yes, we are using a db lifecycle to listen to that "event" and remove deleted entries from releases
There was a problem hiding this comment.
well , I guess discarding the documetn would just unlist it from the release then.
It might be a good discussion with Yannis to check if this is an issue and if we want to work on it on the future , wdyt?
|
Size Change: 0 B Total Size: 2.58 MB ℹ️ View Unchanged
|
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Marc-Roig
reviewed
May 6, 2024
| @@ -25,14 +25,14 @@ export const getPopulatedEntry = async ( | |||
| }; | |||
|
|
|||
| export const getEntryValidStatus = async ( | |||
There was a problem hiding this comment.
cc @jhoward1994 just in case, just in case you want to handle publishing validations backend side this might be useful.
Marc-Roig
reviewed
May 6, 2024
packages/core/content-releases/server/src/controllers/release.ts
Outdated
Show resolved
Hide resolved
joshuaellis
reviewed
May 7, 2024
Comment on lines
+16
to
+25
| const Panel: PanelComponent = () => { | ||
| const { | ||
| slug: contentTypeUid = '', | ||
| id, | ||
| locale, | ||
| } = useParams<{ | ||
| slug: UID.ContentType; | ||
| id: string; | ||
| locale: string; | ||
| }>(); |
There was a problem hiding this comment.
you get model and documentId passed as props to this component, you should use them instead :)
| edit: { options }, | ||
| } = useDocumentLayout(contentTypeUid); | ||
| const { formatMessage, formatDate, formatTime } = useIntl(); | ||
| const { collectionType } = useParams<{ collectionType: string }>(); |
There was a problem hiding this comment.
you also get collectionType as a prop, use that instead
| const { formatAPIError } = useAPIErrorHandler(); | ||
| const [{ query }] = useQueryParams<{ plugins?: { i18n?: { locale?: string } } }>(); | ||
| const locale = query.plugins?.i18n?.locale; | ||
| const { collectionType } = useParams<{ collectionType: string }>(); |
There was a problem hiding this comment.
you get collectionType as a prop
Marc-Roig
reviewed
May 22, 2024
Comment on lines
82
to
+85
| const query = await permissionsManager.sanitizeQuery(ctx.query); | ||
|
|
||
| query.sort = query.groupBy === 'action' ? 'type' : query.groupBy; | ||
| delete query.groupBy; |
There was a problem hiding this comment.
Probably not something related to this PR, but this should contain a yup validation. I don't think the sanitizeQuery is sanitizing non existing filters like "groupBy"
Marc-Roig
reviewed
May 22, 2024
|
|
||
| type ReleaseWithPopulatedActions = Release & { actions: { count: number } }; | ||
|
|
||
| const releaseController = { | ||
| async findMany(ctx: Koa.Context) { | ||
| async findByDocumentAttached(ctx: Koa.Context) { |
There was a problem hiding this comment.
could you add some comment or explanation of what's the responsability of this controller? 🤔
After 2 weeks of being of, I forgot a bit the logic, and I don't quite see what findByDocumentAttached means.
Maybe what confuses me is the "Attached" word
There was a problem hiding this comment.
Also, it feels off that the endpoint is called findByDocumentAttached, but you can send a parameter to find by documents not attached 🤔
Marc-Roig
reviewed
May 22, 2024
Comment on lines
+66
to
+92
| const relatedReleases = await releaseService.findMany({ | ||
| where: { | ||
| releasedAt: null, | ||
| releasedAt: { | ||
| $null: true, | ||
| }, | ||
| actions: { | ||
| target_type: contentTypeUid, | ||
| target_id: entryId, | ||
| }, | ||
| }, | ||
| }); | ||
|
|
||
| const releases = await releaseService.findMany({ | ||
| where: { | ||
| $or: [ | ||
| { | ||
| id: { | ||
| $notIn: relatedReleases.map((release: any) => release.id), | ||
| }, | ||
| }, | ||
| { | ||
| actions: null, | ||
| }, | ||
| ], | ||
| releasedAt: { | ||
| $null: true, | ||
| }, |
There was a problem hiding this comment.
I believe these queries could be inside the service itself.
releases.findEntryReleases({id, populate...})
releases.findNotInEntryReleases({id, ...))
You could also reduce logic here if you do something like:
releases.findDocumentReleases({documentId, locale, populate...})
releases.findNotInDocumentReleases({documentId, locale, ...))
Marc-Roig
reviewed
May 22, 2024
Comment on lines
+67
to
+69
| const documents = await strapi.documents(contentTypeUid).findMany({ locale }); | ||
|
|
||
| return documents[0].id; |
There was a problem hiding this comment.
Use the .findFirst instead, this might load 1M documents if they exist in the database.
|
Don't know if it's something already fixed in the v5 branch , but it's a bit difficult for me to test strapi using multiple users atm. It's not possible for me to refresh the page when I have two tabs (one in incognito) with two different users. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
Migrates and apply new changes on the Content Releases plugin for v5.
Work to do