New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(content-manager): return default locale #20237
base: develop
Are you sure you want to change the base?
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Can you rebase off develop please, your PR should not have this many commits. Also I'm not sure this is the appropriate solution, I think we should be looking at how the injected component works in i18n rather than trying to solve it in the CM. This also assumes i18n is installed and adds locale which isn't necessary true and pollutes the CM domain with i18n concepts, something we try to avoid where possible. |
Yes, one agnostic solution works in i18n makes total sense. |
57f1a77
to
7cbc251
Compare
What does it do?
Added key on InjectionZone to reset internal states.
Now with params.locale as key. Default locale can be persisted after user click on collection.
Why is it needed?
Locale filter doesn't have correct locale loaded when user click on collection type again.
How to test it?
Related issue(s)/PR(s)
Fix #20209