New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/open Guided tour to all admins #20137
base: develop
Are you sure you want to change the base?
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
You should probably rebase this off |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some initial feedback & discussion points :)
packages/core/admin/admin/src/components/GuidedTour/Homepage.tsx
Outdated
Show resolved
Hide resolved
packages/core/admin/admin/src/components/GuidedTour/Homepage.tsx
Outdated
Show resolved
Hide resolved
packages/core/admin/admin/src/components/GuidedTour/Homepage.tsx
Outdated
Show resolved
Hide resolved
packages/core/admin/admin/src/pages/Settings/pages/Users/components/NewUserForm.tsx
Outdated
Show resolved
Hide resolved
d652b90
to
081fb59
Compare
packages/core/admin/admin/src/pages/Settings/pages/Users/components/NewUserForm.tsx
Outdated
Show resolved
Hide resolved
Code all looks good! Let's get the CI going green, then I can QA it 💪🏼 |
…nents/NewUserForm.tsx Co-authored-by: Josh <37798644+joshuaellis@users.noreply.github.com>
Hey @joshuaellis 👋
|
Size Change: +280 B (0%) Total Size: 1.31 MB
ℹ️ View Unchanged
|
@joshuaellis I'm fixing the front tests and since it's been a whiiiiiiiiile I didn't work with tests, you can start to QA I guess 😅 |
I made a new |
I tried to do the same and the Guided tour showed up. Are you sure that the guided tour wasn't finished or skipped before creating the new editor user? |
@joshuaellis would you have some time during the following weeks to help me with the unit front tests? I don't understand the errors when running |
What does it do?
This PR opens the Guided Tour to all admins.
It also changes some text for the
super-admin
GT to be more straightforward.Why is it needed?
It is too bad that the current Guided Tour is only accessible for super-admins (developers). The idea is to also propose it to non-technical people discovering the product to guide them a little bit.
How to test it?
In development environment:
You should get 3 steps for both users which are different based on the user type.
In the production environment:
You should get 4 steps for both users. The extra step is the same step for both which is about inviting a user but it only make sense to have it on production.