Implement display of missing key pairs in wallet settings #20094
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jenkins BuildsClick to see older builds (61)
|
seanstrom
force-pushed
the
seanstrom/display-missing-key-pairs
branch
2 times, most recently
from
6986930
to
31c5c25
Compare
seanstrom
force-pushed
the
seanstrom/display-missing-key-pairs
branch
3 times, most recently
from
179403d
to
1881b4b
Compare
seanstrom
changed the title
seanstrom
force-pushed
the
seanstrom/display-missing-key-pairs
branch
from
1881b4b
to
3bc7033
Compare
seanstrom
force-pushed
the
seanstrom/display-missing-key-pairs
branch
3 times, most recently
from
4efefe5
to
39e46f9
Compare
mohsen-ghafouri
approved these changes
May 20, 2024
There was a problem hiding this comment.
Nice work 🚀 @seanstrom 🙌
You might need to add this issue (#19733) to this PR as it's done here. Thanks!
src/status_im/contexts/settings/wallet/keypairs_and_accounts/actions/view.cljs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Quick question: I can't find this type missing-keypair for the drawer-top component in the Design System. If it's not too much trouble, would you help add the link to the design?
There was a problem hiding this comment.
Ah yeah good question 🙏
I don't think it's an official extension of the component, but here's the designs that feature the drawer-top component with a missing key-pair: https://www.figma.com/design/hLFPHYnuM0pOzgiabtqQ6k/Descoped-Wallet-settings-for-Mobile?node-id=232-33083&t=4nFqEVTIOAcfu0JS-4
Maybe the design system should be updated?
There was a problem hiding this comment.
The type here is still keypair for the drawer-top component. I believe it's just the text (subtitle in our code) change that it needs to receive from the parent instead of hardcoding in the component.
We should confirm with the design team.
There was a problem hiding this comment.
Okay I'll double check with design team 👍
There was a problem hiding this comment.
Still double checking with the design team, but for the moment I've refactored drawer-top component to use a :stored field (similar to the quo/keypair component) for describing whether the key pair is :on-device, :on-keycard, or :missing.
There was a problem hiding this comment.
It should be fine as we have the same in the quo/keypair component. Let's post this information to the Design team to keep them updated. 👍
seanstrom
force-pushed
the
seanstrom/display-missing-key-pairs
branch
4 times, most recently
from
8f03a9b
to
fd03d26
Compare
seanstrom
force-pushed
the
seanstrom/display-missing-key-pairs
branch
2 times, most recently
from
15c3582
to
22b1dff
Compare
seanstrom
force-pushed
the
seanstrom/display-missing-key-pairs
branch
from
2c6a932
to
9de8613
Compare
77% of end-end tests have passedFailed tests (10)Click to expandClass TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestGroupChatMultipleDeviceMergedNewUI:
Class TestWalletOneDevice:
Class TestCommunityMultipleDeviceMerged:
Class TestWalletMultipleDevice:
Class TestCommunityMultipleDeviceMergedTwo:
Expected to fail tests (2)Click to expandClass TestCommunityOneDeviceMerged:
Class TestGroupChatMultipleDeviceMergedNewUI:
Passed tests (40)Click to expandClass TestActivityMultipleDevicePR:
Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestDeepLinksOneDevice:
Class TestWalletOneDevice:
Class TestGroupChatMultipleDeviceMergedNewUI:
Class TestActivityMultipleDevicePRTwo:
Class TestActivityCenterContactRequestMultipleDevicePR:
Class TestCommunityMultipleDeviceMerged:
Class TestCommunityOneDeviceMerged:
Class TestCommunityMultipleDeviceMergedTwo:
|
|
@status-im/mobile-qa can you review these E2E results please? 🙏 |
seanstrom
force-pushed
the
seanstrom/display-missing-key-pairs
branch
from
9de8613
to
44c8c3f
Compare
Hi @seanstrom, thanks for the PR! E2E failures are not related |
seanstrom
force-pushed
the
seanstrom/display-missing-key-pairs
branch
from
44c8c3f
to
5b201ae
Compare
|
Note, this PR is going to use |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #20033
fixes #19733
Summary
Platforms
Areas that maybe impacted
Functional
Steps to test
To test these changes there are some requirements, the user account for testing will need with two devices, and both of those devices must be synced to the user account.
Once the account and devices are setup to sync between the devices:
After changes screen capture
Missing.Key.Pairs.Demo.mov
status: ready