github: factor out common workflows #1196
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(This needs seL4/ci-actions#332 merged before the required actions can trigger, because they point to |
The new reusable workflow feature of GitHub allows us to avoid repeating the workflow definitions and collect them in the ci-actions repo instead. Signed-off-by: Gerwin Klein <gerwin.klein@proofcraft.systems>
Disambiguate from seL4Test runs on pull requests. Signed-off-by: Gerwin Klein <gerwin.klein@proofcraft.systems>
Signed-off-by: Gerwin Klein <gerwin.klein@proofcraft.systems>
axel-h
reviewed
Feb 11, 2024
axel-h
reviewed
Mar 26, 2024
There was a problem hiding this comment.
Maybe rename the file also to clarify this is a generic deploy: sel4test-deploy.yml -> deploy.yml
axel-h
reviewed
Mar 26, 2024
There was a problem hiding this comment.
Maybe rename the file also to clarify this is a generic hw test: sel4test-hw.ym -> test-hw.yml
axel-h
reviewed
Mar 26, 2024
| concurrency: | ||
| group: ${{ github.workflow }}-pr-${{ github.event.number }} | ||
| cancel-in-progress: true | ||
| types: [synchronize, labeled] |
There was a problem hiding this comment.
Was it intentional no drop opened and reopened here?
Suggested change
| types: [synchronize, labeled] | |
| types: [opened, reopened, synchronize, labeled] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can now reuse workflow definitions, which means we can factor them out into the ci-actions repo and re-use over multiple other repositories.
Needs seL4/ci-actions#332 merged first.
The plan is to use this on the seL4 repo first for a while and then deploy to the rest when we are sure that everything works as we want it to.