use correct account status path if the tld is .us, add param for vers… #1360
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ion in Client.get_account_status The paths for the .com and .us account status endpoints have diverged. We now check the tld configured in the Client and use path 'accountStatus' if the tld is .us. We also allow the caller to pass an api version, which defaults to 1 if not passed. This leaves the functionality the same for traders lucky enough to interact with the .com api.
|
@sammchardy If you could take a look at this it would be great. I use the get_account_status function with the us tld and have had to maintain a patch to make get_account_status to work. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ion in Client.get_account_status
The paths for the .com and .us account status endpoints have diverged. We now check the tld configured in the Client and use path 'accountStatus' if the tld is .us. We also allow the caller to pass an api version, which defaults to 1 if not passed. This leaves the functionality the same for traders lucky enough to interact with the .com api.